all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com>
Subject: applied (subset): [PATCH qemu-server v4 0/9] add hotplug tests and fix uncovered bugs
Date: Wed, 28 Oct 2026 14:52:47 +0100	[thread overview]
Message-ID: <179319515551.146114.10549178584694707512.b4-ty@proxmox.com> (raw)
In-Reply-To: <20261023130324.451252-1-d.csapak@proxmox.com>

On Fri, 23 Oct 2026 15:01:03 +0200, Dominik Csapak wrote:
> Recently it was uncovered that hotplugging scsiX >= 14 does not work
> in all situations. Inspired by this, this attempts to add some hotplug
> regression tests by simulating the qmp/hmp environment, recording the
> calls and testing against some invariants.
> 
> This uncovered three additional bugs in the hotplug code:
> * hotplugging a tablet device into an aarch64 vm fails
> * hot unplugging a tablet device into an aarch64 vm left over the keyboard
> * failure to hotplug a disk with iothreads leaves the iothread behind
> 
> [...]

Applied all but 9/9, thanks! The patch 8/9 was accidentally squashed
into a single one compared to v3, so I split it up again and also
adapted a comment in vm_devices_list(). I made 2/9 actually factor out
the battle-tested existing diff helper instead of replacing it with a
new implementation as discussed off-list. In 3/9 I changed the
function and variable names, to avoid the generic 'machine', to make
it explicit that the function is intended for the basic machine types
only. Also added a follow-up to rename the variable in
windows_get_pinned_machine_version().

[1/9] tests: factor out useful commandline mocks for reuse
      commit: a70e9fbb5eb316bcc058f9e3fe69299bd9d9fc7a
[2/9] tests: factor out the diff generation
      commit: a398a2dcedb0a10e2234a6277c1b2310742542cc
[3/9] machine: factor out helper for expanding basic type
      commit: 955c6cf52fd6874224f6a2aca4925b38df2e97c0
[4/9] tests: hotplug: add initial hotplug test harness
      commit: 7b56914c501c8672076f9aa54542dbf36f32ea6c
[5/9] tests: hotplug: add some test cases
      commit: 1f52f2d67051ac36119d868cc49fc00597d8219f
[6/9] tests: hotplug: add test case for adding scsi14 on qemu 11.1
      commit: 2eefb638907a7faf7c03dd68eecdf7a6c16bc32f
[7/9] tests: hotplug: add cases for known defects
      commit: 9fe5b18562017ac8f81425055811a20aab2d06d4
[8/9] hotplug: fix hot unplugging tablet on aarch64
      commit: e4bc59136214050797fc2fc90b54de908b81fdce
[8.5/9] hotplug: fix vm_deviceplug call for 'tablet' and 'keyboard' on aarch64
      commit: 1b4fbc2cbe036270f50866a036ae774d89317e50




      parent reply	other threads:[~2026-10-28 13:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-23 13:01 [PATCH qemu-server v4 0/9] add hotplug tests and fix uncovered bugs Dominik Csapak
2026-10-23 13:01 ` [PATCH qemu-server v4 1/9] tests: factor out useful commandline mocks for reuse Dominik Csapak
2026-10-23 13:01 ` [PATCH qemu-server v4 2/9] tests: factor out the diff generation Dominik Csapak
2026-10-23 13:01 ` [PATCH qemu-server v4 3/9] machine: factor out machine expanding Dominik Csapak
2026-10-23 13:01 ` [PATCH qemu-server v4 4/9] tests: hotplug: add initial hotplug test harness Dominik Csapak
2026-10-23 13:01 ` [PATCH qemu-server v4 5/9] tests: hotplug: add some test cases Dominik Csapak
2026-10-23 13:01 ` [PATCH qemu-server v4 6/9] tests: hotplug: add test case for adding scsi14 on qemu 11.1 Dominik Csapak
2026-10-23 13:01 ` [PATCH qemu-server v4 7/9] tests: hotplug: add cases for known defects Dominik Csapak
2026-10-23 13:01 ` [PATCH qemu-server v4 8/9] hotplug: fix hot unplugging tablet on aarch64 Dominik Csapak
2026-10-23 13:01 ` [PATCH qemu-server v4 9/9] hotplug: remove iothread if adding drive device failed Dominik Csapak
2026-10-28 13:59   ` Fiona Ebner
2026-10-28 13:52 ` Fiona Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179319515551.146114.10549178584694707512.b4-ty@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal