From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id AE5771FF0B3 for ; Wed, 28 Oct 2026 14:53:19 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 7841021314; Wed, 28 Oct 2026 14:53:16 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com, Dominik Csapak Subject: applied (subset): [PATCH qemu-server v4 0/9] add hotplug tests and fix uncovered bugs Date: Wed, 28 Oct 2026 14:52:47 +0100 Message-ID: <179319515551.146114.10549178584694707512.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261023130324.451252-1-d.csapak@proxmox.com> References: <20261023130324.451252-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793195589495 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.211 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FFCBUJK3FSXYAPGSDZ52I322TOIPIOOH X-Message-ID-Hash: FFCBUJK3FSXYAPGSDZ52I322TOIPIOOH X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 23 Oct 2026 15:01:03 +0200, Dominik Csapak wrote: > Recently it was uncovered that hotplugging scsiX >= 14 does not work > in all situations. Inspired by this, this attempts to add some hotplug > regression tests by simulating the qmp/hmp environment, recording the > calls and testing against some invariants. > > This uncovered three additional bugs in the hotplug code: > * hotplugging a tablet device into an aarch64 vm fails > * hot unplugging a tablet device into an aarch64 vm left over the keyboard > * failure to hotplug a disk with iothreads leaves the iothread behind > > [...] Applied all but 9/9, thanks! The patch 8/9 was accidentally squashed into a single one compared to v3, so I split it up again and also adapted a comment in vm_devices_list(). I made 2/9 actually factor out the battle-tested existing diff helper instead of replacing it with a new implementation as discussed off-list. In 3/9 I changed the function and variable names, to avoid the generic 'machine', to make it explicit that the function is intended for the basic machine types only. Also added a follow-up to rename the variable in windows_get_pinned_machine_version(). [1/9] tests: factor out useful commandline mocks for reuse commit: a70e9fbb5eb316bcc058f9e3fe69299bd9d9fc7a [2/9] tests: factor out the diff generation commit: a398a2dcedb0a10e2234a6277c1b2310742542cc [3/9] machine: factor out helper for expanding basic type commit: 955c6cf52fd6874224f6a2aca4925b38df2e97c0 [4/9] tests: hotplug: add initial hotplug test harness commit: 7b56914c501c8672076f9aa54542dbf36f32ea6c [5/9] tests: hotplug: add some test cases commit: 1f52f2d67051ac36119d868cc49fc00597d8219f [6/9] tests: hotplug: add test case for adding scsi14 on qemu 11.1 commit: 2eefb638907a7faf7c03dd68eecdf7a6c16bc32f [7/9] tests: hotplug: add cases for known defects commit: 9fe5b18562017ac8f81425055811a20aab2d06d4 [8/9] hotplug: fix hot unplugging tablet on aarch64 commit: e4bc59136214050797fc2fc90b54de908b81fdce [8.5/9] hotplug: fix vm_deviceplug call for 'tablet' and 'keyboard' on aarch64 commit: 1b4fbc2cbe036270f50866a036ae774d89317e50