all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH container] tools: drop fallback to old device list for passthrough mounts
@ 2026-10-14  9:32 Filip Schauer
  2026-10-20 18:56 ` applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Filip Schauer @ 2026-10-14  9:32 UTC (permalink / raw)
  To: pve-devel

The fallback to /var/lib/lxc/$vmid/devices was originally introduced in
ce1976b85361 ("Add device passthrough") as a temporary measure to handle
package upgrades occurring between lxc-pve-prestart-hook and
lxc-pve-autodev-hook.

A new major release has happened since, so remove the fallback.

Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
---
 src/PVE/LXC/Tools.pm | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/src/PVE/LXC/Tools.pm b/src/PVE/LXC/Tools.pm
index ce2467e..3228b2b 100644
--- a/src/PVE/LXC/Tools.pm
+++ b/src/PVE/LXC/Tools.pm
@@ -122,14 +122,7 @@ sub for_current_passthrough_mounts($&) {
     my ($vmid, $code) = @_;
 
     my $devlist_file = "/var/lib/lxc/$vmid/passthrough/mounts";
-
-    if (-e $devlist_file) {
-        for_devices($devlist_file, $vmid, $code);
-    } else {
-        # Fallback to the old device list file in case a package upgrade
-        # occurs between lxc-pve-prestart-hook and now.
-        for_devices("/var/lib/lxc/$vmid/devices", $vmid, $code);
-    }
+    for_devices($devlist_file, $vmid, $code);
 }
 
 sub for_current_passthrough_devices($&) {
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* applied: [PATCH container] tools: drop fallback to old device list for passthrough mounts
  2026-10-14  9:32 [PATCH container] tools: drop fallback to old device list for passthrough mounts Filip Schauer
@ 2026-10-20 18:56 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2026-10-20 18:56 UTC (permalink / raw)
  To: pve-devel, Filip Schauer

On Wed, 14 Oct 2026 11:32:28 +0200, Filip Schauer wrote:
> The fallback to /var/lib/lxc/$vmid/devices was originally introduced in
> ce1976b85361 ("Add device passthrough") as a temporary measure to handle
> package upgrades occurring between lxc-pve-prestart-hook and
> lxc-pve-autodev-hook.
> 
> A new major release has happened since, so remove the fallback.
> 
> [...]

Applied, thanks!

[1/1] tools: drop fallback to old device list for passthrough mounts
      commit: 68460d9a473be075924cb494419a8bdf5e1d5fdc




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-10-20 19:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-14  9:32 [PATCH container] tools: drop fallback to old device list for passthrough mounts Filip Schauer
2026-10-20 18:56 ` applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal