* [PATCH pve-apiclient] pass parameters for DELETE requests as query string
@ 2026-03-18 13:22 Hannes Laimer
2026-08-25 9:42 ` applied: " Fiona Ebner
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Laimer @ 2026-03-18 13:22 UTC (permalink / raw)
To: pve-devel
The DELETE handler silently dropped all parameters, making it impossible
to call API endpoints that require them.
Encode parameters as query string, the same way GET requests do.
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
src/PVE/APIClient/LWP.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/APIClient/LWP.pm b/src/PVE/APIClient/LWP.pm
index d8472f7..607cdf1 100755
--- a/src/PVE/APIClient/LWP.pm
+++ b/src/PVE/APIClient/LWP.pm
@@ -332,6 +332,7 @@ sub call {
);
} elsif ($method eq 'DELETE') {
+ $uri->query_form($param) if $param;
$response = $ua->request(HTTP::Request::Common::DELETE($uri));
} else {
raise("method $method not implemented\n");
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-25 9:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-18 13:22 [PATCH pve-apiclient] pass parameters for DELETE requests as query string Hannes Laimer
2026-08-25 9:42 ` applied: " Fiona Ebner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.