all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: pdm-devel@lists.proxmox.com,
	Thomas Ellmenreich <t.ellmenreich@proxmox.com>
Subject: applied: [PATCH datacenter-manager 1/1] fix #7135: openid auth: improve error logging
Date: Fri, 21 Aug 2026 13:35:48 +0200	[thread overview]
Message-ID: <178731214859.187715.588193495057111260.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260821102147.220586-1-t.ellmenreich@proxmox.com>


On Fri, 21 Aug 2026 12:21:47 +0200, Thomas Ellmenreich wrote:
> Improve logging when getting the authorization URL fails. Previously,
> the details of the error were completly swallowed, making it difficult
> to diagnose problems connecting to the OpenID Connect Server.
> 
> The new log statement prints out the produced error with all of the
> contexts provided to `anyhow`, instead of just the one on top of the
> stack. Doing so should make OpenID connection errors easier to debug.
> 
> [...]

Applied, thanks for the patch!

I think the way you implemented this makes sense. Having the error with the
entire context in the system logs should make troubleshooting way easier. We
could still consider returning more details in the API response later, if we
desire to, the current change does not limit us from doing so.

It appears that PBS suffers from the same issue, could you maybe send a patch
for there as well? (cc @Chris)


[1/1] fix #7135: openid auth: improve error logging
      commit: e1cd6869fbe448e0d58e6fbc3f0f7a740c0a8dd6

Best regards,
-- 
Lukas Wagner <l.wagner@proxmox.com>




      reply	other threads:[~2026-08-21 11:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21 10:21 [PATCH datacenter-manager 1/1] fix #7135: openid auth: improve error logging Thomas Ellmenreich
2026-08-21 11:35 ` Lukas Wagner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178731214859.187715.588193495057111260.b4-ty@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    --cc=t.ellmenreich@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal