From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 7ACB91FF0AA for ; Fri, 21 Aug 2026 13:40:48 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id C3A5A2158B; Fri, 21 Aug 2026 13:40:47 +0200 (CEST) From: Lukas Wagner To: pdm-devel@lists.proxmox.com, Thomas Ellmenreich In-Reply-To: <20260821102147.220586-1-t.ellmenreich@proxmox.com> References: <20260821102147.220586-1-t.ellmenreich@proxmox.com> Subject: applied: [PATCH datacenter-manager 1/1] fix #7135: openid auth: improve error logging Message-Id: <178731214859.187715.588193495057111260.b4-ty@proxmox.com> Date: Fri, 21 Aug 2026 13:35:48 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787312413000 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.692 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FIBNCAF5775IFAMRYFVDXRTBT5KCOOF7 X-Message-ID-Hash: FIBNCAF5775IFAMRYFVDXRTBT5KCOOF7 X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 21 Aug 2026 12:21:47 +0200, Thomas Ellmenreich wrote: > Improve logging when getting the authorization URL fails. Previously, > the details of the error were completly swallowed, making it difficult > to diagnose problems connecting to the OpenID Connect Server. > > The new log statement prints out the produced error with all of the > contexts provided to `anyhow`, instead of just the one on top of the > stack. Doing so should make OpenID connection errors easier to debug. > > [...] Applied, thanks for the patch! I think the way you implemented this makes sense. Having the error with the entire context in the system logs should make troubleshooting way easier. We could still consider returning more details in the API response later, if we desire to, the current change does not limit us from doing so. It appears that PBS suffers from the same issue, could you maybe send a patch for there as well? (cc @Chris) [1/1] fix #7135: openid auth: improve error logging commit: e1cd6869fbe448e0d58e6fbc3f0f7a740c0a8dd6 Best regards, -- Lukas Wagner