From: Robert Obkircher <r.obkircher@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup v2 0/5] restrict previous manifest reuse checks for push sync jobs
Date: Wed, 22 Jul 2026 13:31:06 +0200 [thread overview]
Message-ID: <178471986678.177215.17528188133445326555.b4-review@b4> (raw)
In-Reply-To: <20260507130135.589100-1-c.ebner@proxmox.com>
On Thu, 07 May 2026 15:01:30 +0200, Christian Ebner <c.ebner@proxmox.com> wrote:
> restrict previous manifest reuse checks for push sync jobs
>
> Restrict and rework the checks for reuse of previous snapshots
> manifest's for push sync jobs, in particular with key and signature
> mismatches for sync jobs with active encryption key.
> In particular, only allow reuse of the previous manifest if either
> the previous manifest is not encrypted, and the push sync will also
> not encrypt or the previous manifest is encrypted with the matching
> active encryption key configured for the sync job, the manifest's
> signature being verified with that key.
>
> [...]
Reviewed-by: Robert Obkircher <r.obkircher@proxmox.com>
--
Robert Obkircher <r.obkircher@proxmox.com>
prev parent reply other threads:[~2026-07-22 11:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 13:01 [PATCH proxmox-backup v2 0/5] restrict previous manifest reuse checks for push sync jobs Christian Ebner
2026-05-07 13:01 ` [PATCH proxmox-backup v2 1/5] datastore: data blob: refactor crypt mode method Christian Ebner
2026-05-07 13:01 ` [PATCH proxmox-backup v2 2/5] datastore: data blob: refactor decoding method Christian Ebner
2026-07-22 11:31 ` Robert Obkircher
2026-05-07 13:01 ` [PATCH proxmox-backup v2 3/5] client: backup writer: pass no crypt config to manifest blob decoder Christian Ebner
2026-05-07 13:01 ` [PATCH proxmox-backup v2 4/5] client: allow skipping signature check on previous manifest fetching Christian Ebner
2026-05-07 13:01 ` [PATCH proxmox-backup v2 5/5] sync: push: gracefully handle previous manifest signature mismatches Christian Ebner
2026-07-22 11:31 ` Robert Obkircher
2026-07-22 14:49 ` Christian Ebner
2026-07-21 11:03 ` [PATCH proxmox-backup v2 0/5] restrict previous manifest reuse checks for push sync jobs Christian Ebner
2026-07-22 11:31 ` Robert Obkircher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178471986678.177215.17528188133445326555.b4-review@b4 \
--to=r.obkircher@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.