[PATCH proxmox-backup v2 0/5] restrict previous manifest reuse checks for push sync jobs

[Christian Ebner <c.ebner@proxmox.com>]

Restrict and rework the checks for reuse of previous snapshots
manifest's for push sync jobs, in particular with key and signature
mismatches for sync jobs with active encryption key.
In particular, only allow reuse of the previous manifest if either
the previous manifest is not encrypted, and the push sync will also
not encrypt or the previous manifest is encrypted with the matching
active encryption key configured for the sync job, the manifest's
signature being verified with that key.

This patches thereby also more gracefully handle an otherwise rather
alerting log message during push sync jobs with configured active
encryption key, stating a key mismatch in the manifest signature
check error.

The series includes also some patches with code style cleanups
encountered while working on the code.

Changes since version 1 (thanks @Fabian for review):
- use boolean flag to skip signature check in download_previous_manifest()
- do not pass crypt config on manifest blob decode
- refine checks for when the previous manifest should be reusable
- drop now outdated checks when pulling reusable index chunks
- refactor DataBlob methods for improved code style


proxmox-backup:

Christian Ebner (5):
  datastore: data blob: refactor crypt mode method
  datastore: data blob: refactor decoding method
  client: backup writer: pass no crypt config to manifest blob decoder
  client: allow skipping signature check on previous manifest fetching
  sync: push: gracefully handle previous manifest signature mismatches

 pbs-client/src/backup_writer.rs   |  23 +++++--
 pbs-datastore/src/data_blob.rs    | 102 ++++++++++++++----------------
 proxmox-backup-client/src/main.rs |   2 +-
 src/server/push.rs                |  81 ++++++++++++++++++------
 4 files changed, 126 insertions(+), 82 deletions(-)


Summary over all repositories:
  4 files changed, 126 insertions(+), 82 deletions(-)

-- 
Generated by murpp 0.11.0