* [PATCH installer] install: fix progress percent reporting when creating root and swap
@ 2026-07-17 11:18 Christoph Heiss
2026-07-17 13:58 ` applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Heiss @ 2026-07-17 11:18 UTC (permalink / raw)
To: pve-devel
Currently the progress reported when using the auto-installer (where it
is most noticeable) is:
INFO: progress 0.0 % - cleanup root-disks
INFO: progress 2.0 % - create partitions
INFO: progress 3.0 % - create LVs
INFO: progress 1.0 % - create swap space
INFO: progress 1.1 % - creating root filesystems
INFO: progress 5.0 % - creating root filesystem
[..]
.. i.e. the progress can go backwards.
Fix it by aligning the two update_progress() calls with the others,
so that the progress is reported as originally intended:
[..]
INFO: progress 4.0 % - create swap space
INFO: progress 4.5 % - creating root filesystems
[..]
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
Proxmox/Install.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
index 788aca4..0387c6e 100644
--- a/Proxmox/Install.pm
+++ b/Proxmox/Install.pm
@@ -1006,12 +1006,12 @@ sub extract_data {
}
if ($swapfile) {
- update_progress(0.04, 0, $maxper, "create swap space");
+ update_progress(0, 0.04, $maxper, "create swap space");
syscmd("mkswap -f $swapfile") == 0
|| die "unable to create swap space\n";
}
- update_progress(0.045, 0, $maxper, "creating root filesystems");
+ update_progress(0, 0.045, $maxper, "creating root filesystems");
foreach my $di (@$bootdevinfo) {
next if !$di->{esp};
--
2.54.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* applied: [PATCH installer] install: fix progress percent reporting when creating root and swap
2026-07-17 11:18 [PATCH installer] install: fix progress percent reporting when creating root and swap Christoph Heiss
@ 2026-07-17 13:58 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2026-07-17 13:58 UTC (permalink / raw)
To: pve-devel, Christoph Heiss
On Fri, 17 Jul 2026 13:18:57 +0200, Christoph Heiss wrote:
> Currently the progress reported when using the auto-installer (where it
> is most noticeable) is:
>
> INFO: progress 0.0 % - cleanup root-disks
> INFO: progress 2.0 % - create partitions
> INFO: progress 3.0 % - create LVs
> INFO: progress 1.0 % - create swap space
> INFO: progress 1.1 % - creating root filesystems
> INFO: progress 5.0 % - creating root filesystem
> [..]
>
> [...]
Applied, thanks!
[1/1] install: fix progress percent reporting when creating root and swap
commit: 997cf6983f4ddbed1f9780f7e0bf6c957e718ee0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-17 13:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-17 11:18 [PATCH installer] install: fix progress percent reporting when creating root and swap Christoph Heiss
2026-07-17 13:58 ` applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.