all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH manager v2] ui: qemu: boot order: warn of missing pxe support for ovmf
@ 2026-06-10 13:40 Dominik Csapak
  2026-06-10 13:43 ` Dominik Csapak
  2026-07-15 20:30 ` applied: " Thomas Lamprecht
  0 siblings, 2 replies; 3+ messages in thread
From: Dominik Csapak @ 2026-06-10 13:40 UTC (permalink / raw)
  To: pve-devel

OVMF can only use PXE/network boot when a virtual RNG device is added
for VMs, but this is not obvious from the UI or the error behavior.

Add a small warning to the boot order edit that says what is necessary.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
---
changes from v1:
* incorporated fionas feedback (thanks!)
* include r-b trailer from fiona

 www/manager6/qemu/BootOrderEdit.js | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/www/manager6/qemu/BootOrderEdit.js b/www/manager6/qemu/BootOrderEdit.js
index 521a3d6e..08e71913 100644
--- a/www/manager6/qemu/BootOrderEdit.js
+++ b/www/manager6/qemu/BootOrderEdit.js
@@ -26,6 +26,7 @@ Ext.define('PVE.qemu.BootOrderPanel', {
             let grid = me.lookup('grid');
             let marker = me.lookup('marker');
             let emptyWarning = me.lookup('emptyWarning');
+            let rngPxeWarning = me.lookup('rngPxeWarning');
 
             marker.originalValue = undefined;
 
@@ -43,6 +44,14 @@ Ext.define('PVE.qemu.BootOrderPanel', {
                         view.inUpdate = false;
                         marker.checkDirty();
                         emptyWarning.setHidden(val !== '');
+
+                        let showRngPxeWarning =
+                            view.vmconfig?.bios === 'ovmf' &&
+                            !view.vmconfig?.rng0 &&
+                            val?.includes('net');
+
+                        rngPxeWarning.setHidden(!showRngPxeWarning);
+
                         grid.getView().refresh();
                     },
                 },
@@ -238,6 +247,13 @@ Ext.define('PVE.qemu.BootOrderPanel', {
             userCls: 'pmx-hint',
             value: gettext('Warning: No devices selected, the VM will probably not boot!'),
         },
+        {
+            xtype: 'displayfield',
+            reference: 'rngPxeWarning',
+            userCls: 'pmx-hint',
+            hidden: true,
+            value: gettext('Warning: For PXE boot with OVMF, you must add a VirtIO RNG device!'),
+        },
         {
             // for dirty marking and 'reset' function
             xtype: 'field',
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH manager v2] ui: qemu: boot order: warn of missing pxe support for ovmf
  2026-06-10 13:40 [PATCH manager v2] ui: qemu: boot order: warn of missing pxe support for ovmf Dominik Csapak
@ 2026-06-10 13:43 ` Dominik Csapak
  2026-07-15 20:30 ` applied: " Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Dominik Csapak @ 2026-06-10 13:43 UTC (permalink / raw)
  To: pve-devel

this is actually v3, sorry^^

On 6/10/26 3:41 PM, Dominik Csapak wrote:
> OVMF can only use PXE/network boot when a virtual RNG device is added
> for VMs, but this is not obvious from the UI or the error behavior.
> 
> Add a small warning to the boot order edit that says what is necessary.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> changes from v1:
> * incorporated fionas feedback (thanks!)
> * include r-b trailer from fiona
> 
>   www/manager6/qemu/BootOrderEdit.js | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
> 
> diff --git a/www/manager6/qemu/BootOrderEdit.js b/www/manager6/qemu/BootOrderEdit.js
> index 521a3d6e..08e71913 100644
> --- a/www/manager6/qemu/BootOrderEdit.js
> +++ b/www/manager6/qemu/BootOrderEdit.js
> @@ -26,6 +26,7 @@ Ext.define('PVE.qemu.BootOrderPanel', {
>               let grid = me.lookup('grid');
>               let marker = me.lookup('marker');
>               let emptyWarning = me.lookup('emptyWarning');
> +            let rngPxeWarning = me.lookup('rngPxeWarning');
>   
>               marker.originalValue = undefined;
>   
> @@ -43,6 +44,14 @@ Ext.define('PVE.qemu.BootOrderPanel', {
>                           view.inUpdate = false;
>                           marker.checkDirty();
>                           emptyWarning.setHidden(val !== '');
> +
> +                        let showRngPxeWarning =
> +                            view.vmconfig?.bios === 'ovmf' &&
> +                            !view.vmconfig?.rng0 &&
> +                            val?.includes('net');
> +
> +                        rngPxeWarning.setHidden(!showRngPxeWarning);
> +
>                           grid.getView().refresh();
>                       },
>                   },
> @@ -238,6 +247,13 @@ Ext.define('PVE.qemu.BootOrderPanel', {
>               userCls: 'pmx-hint',
>               value: gettext('Warning: No devices selected, the VM will probably not boot!'),
>           },
> +        {
> +            xtype: 'displayfield',
> +            reference: 'rngPxeWarning',
> +            userCls: 'pmx-hint',
> +            hidden: true,
> +            value: gettext('Warning: For PXE boot with OVMF, you must add a VirtIO RNG device!'),
> +        },
>           {
>               // for dirty marking and 'reset' function
>               xtype: 'field',





^ permalink raw reply	[flat|nested] 3+ messages in thread

* applied: [PATCH manager v2] ui: qemu: boot order: warn of missing pxe support for ovmf
  2026-06-10 13:40 [PATCH manager v2] ui: qemu: boot order: warn of missing pxe support for ovmf Dominik Csapak
  2026-06-10 13:43 ` Dominik Csapak
@ 2026-07-15 20:30 ` Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2026-07-15 20:30 UTC (permalink / raw)
  To: pve-devel, Dominik Csapak

On Wed, 10 Jun 2026 15:40:36 +0200, Dominik Csapak wrote:
> OVMF can only use PXE/network boot when a virtual RNG device is added
> for VMs, but this is not obvious from the UI or the error behavior.
> 
> Add a small warning to the boot order edit that says what is necessary.

Applied, thanks!

[1/1] ui: qemu: boot order: warn of missing pxe support for ovmf
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=54af22f454a2cea2d96534384ffed336c8656538




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-07-15 20:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-10 13:40 [PATCH manager v2] ui: qemu: boot order: warn of missing pxe support for ovmf Dominik Csapak
2026-06-10 13:43 ` Dominik Csapak
2026-07-15 20:30 ` applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal