all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, pdm-devel@lists.proxmox.com
Subject: Re: [PATCH datacenter-manager 1/3] ui: d/rules: don't generate debuginfo for the UI
Date: Tue, 07 Jul 2026 16:18:18 +0200	[thread overview]
Message-ID: <1783432989.nn95o39zow.astroid@yuna.none> (raw)
In-Reply-To: <20260706114822.2751086-2-d.csapak@proxmox.com>

On July 6, 2026 1:44 pm, Dominik Csapak wrote:
> It's built to wasm, which does not have dbgsym so generating these is
> just unnecessary waste. Omitting this saves us ~20s per 'make deb' and
> should produce identical binaries since wasm-bindgen strips the debug
> info anyway.

it only strips it because we tell it to, right? at some point, we might
want to reconsider and ship a debug variant (and allow loading it via
the API service) to make debugging things easier for users? but I guess
at the moment the debugging story is not too great in general..

> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  ui/debian/rules | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/ui/debian/rules b/ui/debian/rules
> index 8a81f126..b3b3b078 100755
> --- a/ui/debian/rules
> +++ b/ui/debian/rules
> @@ -27,12 +27,13 @@ ifneq ($(DEB_DISTRIBUTION),UNRELEASED)
>  endif
>  
>  	$(CARGO) prepare-debian $(CURDIR)/debian/cargo_registry --link-from-system
> +	sed -e 's/^debug = true$$/debug = false/g' debian/cargo_home/config.toml
>  	echo "\nlto=\"fat\"" >> debian/cargo_home/config.toml
>  	echo "\nopt-level=\"s\"" >> debian/cargo_home/config.toml
>  	echo "\ncodegen-units=1" >> debian/cargo_home/config.toml
>  	# patch cargo_home config to use lld with wasm, otherwise the build fails
>  	echo "\n[target.wasm32-unknown-unknown]" >> debian/cargo_home/config.toml
> -	cat debian/cargo_home/config.toml | sed "s/linker=[^']\+/linker=rust-lld/" | grep "^rustflags = " >> debian/cargo_home/config.toml
> +	cat debian/cargo_home/config.toml | sed -e "s/linker=[^']\+/linker=rust-lld/" -e "s/'-C', 'debuginfo=[^']*', //g" | grep "^rustflags = " >> debian/cargo_home/config.toml

I think this is missing the `strip` part of rustflags here? though I
haven't tested whether it's more effecient to let rustc strip than to
let wasm-bindgen do it later..

>  	dh_auto_configure
>  
>  override_dh_strip:
> -- 
> 2.47.3
> 
> 
> 
> 
> 
> 




  reply	other threads:[~2026-07-07 14:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06 11:44 [PATCH datacenter-manager 0/3] ui: reduce compilation time for relase builds Dominik Csapak
2026-07-06 11:44 ` [PATCH datacenter-manager 1/3] ui: d/rules: don't generate debuginfo for the UI Dominik Csapak
2026-07-07 14:18   ` Fabian Grünbichler [this message]
2026-07-06 11:44 ` [PATCH datacenter-manager 2/3] ui: d/rules: use thin instead of fat LTO Dominik Csapak
2026-07-07 14:05   ` Fabian Grünbichler
2026-07-07 14:10     ` Dominik Csapak
2026-07-07 14:51       ` Fabian Grünbichler
2026-07-07 21:53     ` Thomas Lamprecht
2026-07-08  7:11       ` Fabian Grünbichler
2026-07-08  8:44         ` Robert Obkircher
2026-07-08  9:38           ` Fabian Grünbichler
2026-07-06 11:44 ` [PATCH datacenter-manager 3/3] ui: d/rules: don't limit compilation to 1 codgen-unit Dominik Csapak
2026-07-08 10:27 ` [PATCH datacenter-manager 0/3] ui: reduce compilation time for relase builds Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1783432989.nn95o39zow.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal