From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id A7CE01FF146 for ; Tue, 07 Jul 2026 16:18:54 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 5DCF521438; Tue, 07 Jul 2026 16:18:54 +0200 (CEST) Date: Tue, 07 Jul 2026 16:18:18 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= Subject: Re: [PATCH datacenter-manager 1/3] ui: d/rules: don't generate debuginfo for the UI To: Dominik Csapak , pdm-devel@lists.proxmox.com References: <20260706114822.2751086-1-d.csapak@proxmox.com> <20260706114822.2751086-2-d.csapak@proxmox.com> In-Reply-To: <20260706114822.2751086-2-d.csapak@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1783432989.nn95o39zow.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783433894008 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.133 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5IIM723HO56UZT3AN2Y5MDU2QKOSJNTB X-Message-ID-Hash: 5IIM723HO56UZT3AN2Y5MDU2QKOSJNTB X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On July 6, 2026 1:44 pm, Dominik Csapak wrote: > It's built to wasm, which does not have dbgsym so generating these is > just unnecessary waste. Omitting this saves us ~20s per 'make deb' and > should produce identical binaries since wasm-bindgen strips the debug > info anyway. it only strips it because we tell it to, right? at some point, we might want to reconsider and ship a debug variant (and allow loading it via the API service) to make debugging things easier for users? but I guess at the moment the debugging story is not too great in general.. > Signed-off-by: Dominik Csapak > --- > ui/debian/rules | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/ui/debian/rules b/ui/debian/rules > index 8a81f126..b3b3b078 100755 > --- a/ui/debian/rules > +++ b/ui/debian/rules > @@ -27,12 +27,13 @@ ifneq ($(DEB_DISTRIBUTION),UNRELEASED) > endif > =20 > $(CARGO) prepare-debian $(CURDIR)/debian/cargo_registry --link-from-sys= tem > + sed -e 's/^debug =3D true$$/debug =3D false/g' debian/cargo_home/config= .toml > echo "\nlto=3D\"fat\"" >> debian/cargo_home/config.toml > echo "\nopt-level=3D\"s\"" >> debian/cargo_home/config.toml > echo "\ncodegen-units=3D1" >> debian/cargo_home/config.toml > # patch cargo_home config to use lld with wasm, otherwise the build fai= ls > echo "\n[target.wasm32-unknown-unknown]" >> debian/cargo_home/config.to= ml > - cat debian/cargo_home/config.toml | sed "s/linker=3D[^']\+/linker=3Drus= t-lld/" | grep "^rustflags =3D " >> debian/cargo_home/config.toml > + cat debian/cargo_home/config.toml | sed -e "s/linker=3D[^']\+/linker=3D= rust-lld/" -e "s/'-C', 'debuginfo=3D[^']*', //g" | grep "^rustflags =3D " >= > debian/cargo_home/config.toml I think this is missing the `strip` part of rustflags here? though I haven't tested whether it's more effecient to let rustc strip than to let wasm-bindgen do it later.. > dh_auto_configure > =20 > override_dh_strip: > --=20 > 2.47.3 >=20 >=20 >=20 >=20 >=20 >=20