From: Lukas Wagner <l.wagner@proxmox.com>
To: pdm-devel@lists.proxmox.com,
Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: applied: [PATCH proxmox-datacenter-manager] overview: make ha-state non-translatable
Date: Fri, 19 Jun 2026 09:33:01 +0200 [thread overview]
Message-ID: <178185438188.72218.1547667722531749291.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260603080018.131249-1-m.sandoval@proxmox.com>
On Wed, 03 Jun 2026 10:00:17 +0200, Maximiliano Sandoval wrote:
> There is no point in translating "{0}".
>
> We additionally replace the "none" string with "None", since there isn't
> any HA state called "none". The capitalization makes it clear that there
> is no state rather than being in a state called "none".
>
>
> [...]
Applied, thanks!
Changed the commit subject to make it a bit more clear. Also, as discussed in
person, I dropped the part changing the captitalization of 'none'. I don't think
that capitalization is a good distinction to have between a state enum value and
no state. Also, for the user the distinction does not really matter here, so I
left it as is to leave it more consistent.
[1/1] ui: guest overview: ha-state: don't translate string containing only a variable
commit: 390f101fb0f3dd9ce89743ee930f63df82009bc6
Best regards,
--
Lukas Wagner <l.wagner@proxmox.com>
prev parent reply other threads:[~2026-06-19 7:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 8:00 [PATCH proxmox-datacenter-manager] overview: make ha-state non-translatable Maximiliano Sandoval
2026-06-19 7:33 ` Lukas Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178185438188.72218.1547667722531749291.b4-ty@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.