From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A6F3E1FF142 for ; Fri, 19 Jun 2026 09:38:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5F28D6ACF; Fri, 19 Jun 2026 09:38:17 +0200 (CEST) From: Lukas Wagner To: pdm-devel@lists.proxmox.com, Maximiliano Sandoval In-Reply-To: <20260603080018.131249-1-m.sandoval@proxmox.com> References: <20260603080018.131249-1-m.sandoval@proxmox.com> Subject: applied: [PATCH proxmox-datacenter-manager] overview: make ha-state non-translatable Message-Id: <178185438188.72218.1547667722531749291.b4-ty@proxmox.com> Date: Fri, 19 Jun 2026 09:33:01 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781854660177 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DQPOS2VRMIG26JEDZMH5IYKC77RK5NIR X-Message-ID-Hash: DQPOS2VRMIG26JEDZMH5IYKC77RK5NIR X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 03 Jun 2026 10:00:17 +0200, Maximiliano Sandoval wrote: > There is no point in translating "{0}". > > We additionally replace the "none" string with "None", since there isn't > any HA state called "none". The capitalization makes it clear that there > is no state rather than being in a state called "none". > > > [...] Applied, thanks! Changed the commit subject to make it a bit more clear. Also, as discussed in person, I dropped the part changing the captitalization of 'none'. I don't think that capitalization is a good distinction to have between a state enum value and no state. Also, for the user the distinction does not really matter here, so I left it as is to leave it more consistent. [1/1] ui: guest overview: ha-state: don't translate string containing only a variable commit: 390f101fb0f3dd9ce89743ee930f63df82009bc6 Best regards, -- Lukas Wagner