* [PATCH pve-manager v3] fix #6348: ui: bulk action: use options tag style
@ 2026-05-29 13:59 Erik Fastermann
2026-06-01 13:55 ` applied: " Dominik Csapak
0 siblings, 1 reply; 2+ messages in thread
From: Erik Fastermann @ 2026-05-29 13:59 UTC (permalink / raw)
To: pve-devel; +Cc: Erik Fastermann
Use the tag style configured in the options for the bulk action table or
the default if set to none. This improves visual consistency and makes
tagged resources easier to identify at a glance.
Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
---
changes since v2:
* use the default tag style if none is configured
www/manager6/UIOptions.js | 16 ++++++++++++----
www/manager6/dc/OptionView.js | 4 ++--
www/manager6/form/VMSelector.js | 2 ++
3 files changed, 16 insertions(+), 6 deletions(-)
diff --git a/www/manager6/UIOptions.js b/www/manager6/UIOptions.js
index 99b999b7..8c4674af 100644
--- a/www/manager6/UIOptions.js
+++ b/www/manager6/UIOptions.js
@@ -60,12 +60,20 @@ Ext.define('PVE.UIOptions', {
let overrides = style?.['color-map'];
PVE.UIOptions.updateTagOverrides(PVE.UIOptions.parseTagOverrides(overrides ?? ''));
+ Ext.ComponentQuery.query('pveResourceTree')[0].setUserCls(
+ PVE.UIOptions.tagStyleClass(style),
+ );
+ Ext.ComponentQuery.query('vmselector').forEach((component) => {
+ component.setUserCls(PVE.UIOptions.tagStyleClass(style, true));
+ });
+ },
+
+ tagStyleClass: function (style, replaceNone = false) {
let shape = style?.shape ?? 'circle';
- if (shape === '__default__') {
- style = 'circle';
+ if (shape === '__default__' || (shape === 'none' && replaceNone)) {
+ shape = 'circle';
}
-
- Ext.ComponentQuery.query('pveResourceTree')[0].setUserCls(`proxmox-tags-${shape}`);
+ return `proxmox-tags-${shape}`;
},
tagTreeStyles: {
diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc/OptionView.js
index da9d216b..dc12aa7e 100644
--- a/www/manager6/dc/OptionView.js
+++ b/www/manager6/dc/OptionView.js
@@ -393,7 +393,7 @@ Ext.define('PVE.dc.OptionView', {
let colors = PVE.UIOptions.parseTagOverrides(value?.['color-map']);
let shape = value.shape;
let shapeText = PVE.UIOptions.tagTreeStyles[shape ?? '__default__'];
- let txt = Ext.String.format(gettext('Tree Shape: {0}'), shapeText);
+ let txt = Ext.String.format(gettext('Shape: {0}'), shapeText);
let orderText = PVE.UIOptions.tagOrderOptions[value.ordering ?? '__default__'];
txt += `, ${Ext.String.format(gettext('Ordering: {0}'), orderText)}`;
if (value['case-sensitive']) {
@@ -457,7 +457,7 @@ Ext.define('PVE.dc.OptionView', {
{
name: 'shape',
xtype: 'proxmoxComboGrid',
- fieldLabel: gettext('Tree Shape'),
+ fieldLabel: gettext('Shape'),
valueField: 'value',
displayField: 'display',
allowBlank: false,
diff --git a/www/manager6/form/VMSelector.js b/www/manager6/form/VMSelector.js
index 57aa73a7..a9e90b04 100644
--- a/www/manager6/form/VMSelector.js
+++ b/www/manager6/form/VMSelector.js
@@ -267,6 +267,8 @@ Ext.define('PVE.form.VMSelector', {
me.getSelectionModel().selectAll(false);
});
}
+
+ me.userCls = PVE.UIOptions.tagStyleClass(PVE.UIOptions.options['tag-style'], true);
},
});
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* applied: [PATCH pve-manager v3] fix #6348: ui: bulk action: use options tag style
2026-05-29 13:59 [PATCH pve-manager v3] fix #6348: ui: bulk action: use options tag style Erik Fastermann
@ 2026-06-01 13:55 ` Dominik Csapak
0 siblings, 0 replies; 2+ messages in thread
From: Dominik Csapak @ 2026-06-01 13:55 UTC (permalink / raw)
To: pve-devel, Erik Fastermann
On Fri, 29 May 2026 15:59:37 +0200, Erik Fastermann wrote:
> Use the tag style configured in the options for the bulk action table or
> the default if set to none. This improves visual consistency and makes
> tagged resources easier to identify at a glance.
>
>
Applied, thanks!
[1/1] fix #6348: ui: bulk action: use options tag style
commit: 2cf29dbc187e9f2bd65f81ccc7ad0d6bb57d3901
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-01 13:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-29 13:59 [PATCH pve-manager v3] fix #6348: ui: bulk action: use options tag style Erik Fastermann
2026-06-01 13:55 ` applied: " Dominik Csapak
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.