From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pdm-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com>
Subject: partially-applied: [PATCH datacenter-manager/installer/proxmox 0/3] use correct email validation in auto-installer ui
Date: Thu, 28 May 2026 13:00:38 +0200 [thread overview]
Message-ID: <177996246916.1893343.5426398522472173115.b4-ty@b4> (raw)
In-Reply-To: <20260527130611.2995147-1-d.csapak@proxmox.com>
On Wed, 27 May 2026 15:05:56 +0200, Dominik Csapak wrote:
> to do that we move the email validation from the installer-common crate
> to the installer-types crate which is accessible from PDM too.
>
> Not super sure about the deps for proxmox-installer-types, but I guess
> it doesn't make a difference if we always add the schema/regex
> dependency or depend on the 'api-types' feature in pve-installer
>
> [...]
Applied the proxmox part, thanks!
Nit: I'd have appreciated if your commit message explained for why we "don't
only want this when we have the api types" in the commit message.
[proxmox]
[1/1] installer types: move email validation from proxmox-installer-common
commit: b9bc28082f820dbf88f8dcc02ba2250fc999f9d0
prev parent reply other threads:[~2026-05-28 11:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 13:05 [PATCH datacenter-manager/installer/proxmox 0/3] use correct email validation in auto-installer ui Dominik Csapak
2026-05-27 13:05 ` [PATCH proxmox 1/3] installer types: move email validation from proxmox-installer-common Dominik Csapak
2026-05-27 13:05 ` [PATCH pve-installer 2/3] use email validation from installer-types Dominik Csapak
2026-05-27 13:05 ` [PATCH datacenter-manager 3/3] ui: auto-installer: " Dominik Csapak
2026-05-28 11:00 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177996246916.1893343.5426398522472173115.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.