From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id AAA361FF13C for ; Thu, 28 May 2026 13:00:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 255E51377F; Thu, 28 May 2026 13:00:49 +0200 (CEST) From: Thomas Lamprecht To: pdm-devel@lists.proxmox.com, Dominik Csapak Subject: partially-applied: [PATCH datacenter-manager/installer/proxmox 0/3] use correct email validation in auto-installer ui Date: Thu, 28 May 2026 13:00:38 +0200 Message-ID: <177996246916.1893343.5426398522472173115.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260527130611.2995147-1-d.csapak@proxmox.com> References: <20260527130611.2995147-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779966018498 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XQHUQWY7OBJGLWDGLHKCE7QTUSHTJZDL X-Message-ID-Hash: XQHUQWY7OBJGLWDGLHKCE7QTUSHTJZDL X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 27 May 2026 15:05:56 +0200, Dominik Csapak wrote: > to do that we move the email validation from the installer-common crate > to the installer-types crate which is accessible from PDM too. > > Not super sure about the deps for proxmox-installer-types, but I guess > it doesn't make a difference if we always add the schema/regex > dependency or depend on the 'api-types' feature in pve-installer > > [...] Applied the proxmox part, thanks! Nit: I'd have appreciated if your commit message explained for why we "don't only want this when we have the api types" in the commit message. [proxmox] [1/1] installer types: move email validation from proxmox-installer-common commit: b9bc28082f820dbf88f8dcc02ba2250fc999f9d0