all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH datacenter-manager] ui: guest view: improve contrast for placeholder text/icon
@ 2026-05-27  7:07 Lukas Wagner
  2026-05-27  8:02 ` applied: " Dominik Csapak
  0 siblings, 1 reply; 2+ messages in thread
From: Lukas Wagner @ 2026-05-27  7:07 UTC (permalink / raw)
  To: pdm-devel

The icon and status text is shown if there is e.g. no guest matching the
current filter. The "NeutralAlt" color does not have a good enough
contrast to be clearly legible (especially in dark mode), so use default
text color instead.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 ui/src/guests.rs | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/ui/src/guests.rs b/ui/src/guests.rs
index c912867e..85faf71a 100644
--- a/ui/src/guests.rs
+++ b/ui/src/guests.rs
@@ -24,7 +24,7 @@ use proxmox_yew_comp::{
     LoadableComponentScope, LoadableComponentScopeExt, LoadableComponentState,
 };
 
-use pwt::css::{AlignItems, ColorScheme, FlexFit, FontColor, FontStyle, JustifyContent};
+use pwt::css::{AlignItems, ColorScheme, FlexFit, FontStyle, JustifyContent};
 use pwt::prelude::*;
 use pwt::props::{
     ContainerBuilder, CssPaddingBuilder, ExtractPrimaryKey, StorageLocation, WidgetBuilder,
@@ -614,17 +614,13 @@ fn empty_state(icon: &str, title: String, hint: String) -> Html {
         .class(AlignItems::Center)
         .gap(2)
         .padding(4)
-        .with_child(Fa::new(icon).large_3x().class(FontColor::NeutralAlt))
+        .with_child(Fa::new(icon).large_3x())
         .with_child(
             Container::from_tag("span")
                 .class(FontStyle::TitleMedium)
                 .with_child(title),
         )
-        .with_child(
-            Container::from_tag("span")
-                .class(FontColor::NeutralAlt)
-                .with_child(hint),
-        )
+        .with_child(Container::from_tag("span").with_child(hint))
         .into()
 }
 
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* applied: [PATCH datacenter-manager] ui: guest view: improve contrast for placeholder text/icon
  2026-05-27  7:07 [PATCH datacenter-manager] ui: guest view: improve contrast for placeholder text/icon Lukas Wagner
@ 2026-05-27  8:02 ` Dominik Csapak
  0 siblings, 0 replies; 2+ messages in thread
From: Dominik Csapak @ 2026-05-27  8:02 UTC (permalink / raw)
  To: pdm-devel, Lukas Wagner

On Wed, 27 May 2026 09:07:33 +0200, Lukas Wagner wrote:
> The icon and status text is shown if there is e.g. no guest matching the
> current filter. The "NeutralAlt" color does not have a good enough
> contrast to be clearly legible (especially in dark mode), so use default
> text color instead.
> 
> 

Applied, thanks!

[1/1] ui: guest view: improve contrast for placeholder text/icon
      commit: c1a50b218ad0f456ec5ac75e2f057eb9965cfc69




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-05-27  8:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-27  7:07 [PATCH datacenter-manager] ui: guest view: improve contrast for placeholder text/icon Lukas Wagner
2026-05-27  8:02 ` applied: " Dominik Csapak

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal