From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com>
Subject: applied: [PATCH manager v2] ui: sdn: fabrics: node edit: prevent adding multiple ipv6 columns
Date: Wed, 20 May 2026 16:14:18 +0200 [thread overview]
Message-ID: <177928645748.422707.6785465301507315729.b4-ty@b4> (raw)
In-Reply-To: <20260520132533.3060077-1-d.csapak@proxmox.com>
On Wed, 20 May 2026 15:24:46 +0200, Dominik Csapak wrote:
> modifying a class member is always dangerous, since it modifies the
> object on the original class prototype, so pushing into it happens on
> every instance creation. This means every time 'Add Node' is clicked
> for a fabric with ipv6 support another ipv6 column is added.
>
> To prevent this, copy the list of common columns in initComponent
> and push into that instead.
>
> [...]
Applied, thanks!
[1/1] ui: sdn: fabrics: node edit: prevent adding multiple ipv6 columns
commit: 7ecaaa9953235d0cad0d64bb26da022e5330e034
prev parent reply other threads:[~2026-05-20 14:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 13:24 [PATCH manager v2] ui: sdn: fabrics: node edit: prevent adding multiple ipv6 columns Dominik Csapak
2026-05-20 14:14 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177928645748.422707.6785465301507315729.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.