From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id B73131FF13B
	for <inbox@lore.proxmox.com>; Wed, 20 May 2026 16:15:54 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id B6BCCB3A7;
	Wed, 20 May 2026 16:15:51 +0200 (CEST)
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: applied: [PATCH manager v2] ui: sdn: fabrics: node edit: prevent
 adding multiple ipv6 columns
Date: Wed, 20 May 2026 16:14:18 +0200
Message-ID: <177928645748.422707.6785465301507315729.b4-ty@b4>
X-Mailer: git-send-email 2.47.3
In-Reply-To: <20260520132533.3060077-1-d.csapak@proxmox.com>
References: <20260520132533.3060077-1-d.csapak@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1779286502135
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.004 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: GLSPD7EUTTOJSVZIIIMK7AKMNIEZBSMQ
X-Message-ID-Hash: GLSPD7EUTTOJSVZIIIMK7AKMNIEZBSMQ
X-MailFrom: t.lamprecht@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On Wed, 20 May 2026 15:24:46 +0200, Dominik Csapak wrote:
> modifying a class member is always dangerous, since it modifies the
> object on the original class prototype, so pushing into it happens on
> every instance creation. This means every time 'Add Node' is clicked
> for a fabric with ipv6 support another ipv6 column is added.
> 
> To prevent this, copy the list of common columns in initComponent
> and push into that instead.
> 
> [...]

Applied, thanks!

[1/1] ui: sdn: fabrics: node edit: prevent adding multiple ipv6 columns
      commit: 7ecaaa9953235d0cad0d64bb26da022e5330e034