From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Gabriel Goller <g.goller@proxmox.com>
Subject: applied: [PATCH manager] network-interface-pinning: ignore comments in .link parser
Date: Wed, 20 May 2026 13:51:24 +0200 [thread overview]
Message-ID: <177927788146.204983.17586274384659440944.b4-ty@b4> (raw)
In-Reply-To: <20260520095613.86640-1-g.goller@proxmox.com>
On Wed, 20 May 2026 11:55:45 +0200, Gabriel Goller wrote:
> The parser for the systemd .link files didn't support comments. This
> means executing `pve-network-interface-pinning generate` after pinning
> interfaces with the installer was broken because we add a comment there.
>
> Skip lines starting with '#' or ';' while parsing (according to `man
> systemd.syntax`).
>
> [...]
Applied, thanks!
[1/1] network-interface-pinning: ignore comments in .link parser
commit: f8a0e7116113fd8c5a32d32bf5ac73a0e7e87be5
prev parent reply other threads:[~2026-05-20 11:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 9:55 [PATCH manager] network-interface-pinning: ignore comments in .link parser Gabriel Goller
2026-05-20 10:22 ` Robert Obkircher
2026-05-20 11:51 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177927788146.204983.17586274384659440944.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.