From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 8E3B91FF13B
	for <inbox@lore.proxmox.com>; Wed, 20 May 2026 13:56:04 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id D2F64477B;
	Wed, 20 May 2026 13:56:00 +0200 (CEST)
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com,
	Gabriel Goller <g.goller@proxmox.com>
Subject: applied: [PATCH manager] network-interface-pinning: ignore comments
 in .link parser
Date: Wed, 20 May 2026 13:51:24 +0200
Message-ID: <177927788146.204983.17586274384659440944.b4-ty@b4>
X-Mailer: git-send-email 2.47.3
In-Reply-To: <20260520095613.86640-1-g.goller@proxmox.com>
References: <20260520095613.86640-1-g.goller@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1779278111142
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.004 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: JNIHKEUSUVWEN7JI4B5DZBHAKMF2HGNE
X-Message-ID-Hash: JNIHKEUSUVWEN7JI4B5DZBHAKMF2HGNE
X-MailFrom: t.lamprecht@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On Wed, 20 May 2026 11:55:45 +0200, Gabriel Goller wrote:
> The parser for the systemd .link files didn't support comments. This
> means executing `pve-network-interface-pinning generate` after pinning
> interfaces with the installer was broken because we add a comment there.
> 
> Skip lines starting with '#' or ';' while parsing (according to `man
> systemd.syntax`).
> 
> [...]

Applied, thanks!

[1/1] network-interface-pinning: ignore comments in .link parser
      commit: f8a0e7116113fd8c5a32d32bf5ac73a0e7e87be5