[PATCH manager 1/3] ui: sdn: interface panel: limit heigh

[PATCH manager 1/3] ui: sdn: interface panel: limit heigh

[Dominik Csapak]

so that in the case a node has many network interface, it can still be
used on smaller screens. Without that limit the edit window may grow
beyond the viewport.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/sdn/fabrics/InterfacePanel.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/www/manager6/sdn/fabrics/InterfacePanel.js b/www/manager6/sdn/fabrics/InterfacePanel.js
index ab2162b1..5632104a 100644
--- a/www/manager6/sdn/fabrics/InterfacePanel.js
+++ b/www/manager6/sdn/fabrics/InterfacePanel.js
@@ -13,6 +13,8 @@ Ext.define('PVE.sdn.Fabric.InterfacePanel', {
         type: 'checkboxmodel',
     },
 
+    maxHeight: 500,
+
     commonColumns: [
         {
             text: gettext('Status'),
-- 
2.47.3

[PATCH manager 2/3] ui: sdn: redistribution grid: make style consistent

[Dominik Csapak]

as with the other grids that are editable:
* remove button instead of remove action
* add button below and on the left side

in this case also add an empty text and add a minimum height to show it.
(data needs to be initialized for it to show correctly)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 .../sdn/fabrics/RedistributionGrid.js         | 31 +++++++++++--------
 1 file changed, 18 insertions(+), 13 deletions(-)

diff --git a/www/manager6/sdn/fabrics/RedistributionGrid.js b/www/manager6/sdn/fabrics/RedistributionGrid.js
index 7dfd4d49..34af5375 100644
--- a/www/manager6/sdn/fabrics/RedistributionGrid.js
+++ b/www/manager6/sdn/fabrics/RedistributionGrid.js
@@ -15,20 +15,26 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', {
 
     store: {
         model: 'PVE.sdn.Fabric.Redistribution',
+        data: [],
     },
 
-    tbar: [
-        '->',
+    bbar: [
         {
             text: gettext('Add'),
             handler: 'addRedistribution',
         },
     ],
 
+    minHeight: 100,
+
     border: false,
 
     columns: [],
 
+    viewConfig: {
+        emptyText: gettext('No entries configured'),
+    },
+
     controller: {
         xclass: 'Ext.app.ViewController',
 
@@ -44,8 +50,9 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', {
             me.handleUpdate();
         },
 
-        deleteRedistribution: function (table, rI, cI, item, e, rec) {
+        deleteRedistribution: function (btn) {
             let me = this;
+            let rec = btn.getWidgetRecord();
             me.getView().getStore().remove(rec);
             me.handleUpdate();
         },
@@ -108,16 +115,14 @@ Ext.define('PVE.sdn.Fabric.RedistributionGrid', {
             },
             ...me.getAdditionalColumns(),
             {
-                text: gettext('Action'),
-                xtype: 'actioncolumn',
-                width: 100,
-                items: [
-                    {
-                        tooltip: gettext('Delete'),
-                        handler: 'deleteRedistribution',
-                        iconCls: 'fa critical fa-trash-o',
-                    },
-                ],
+                xtype: 'widgetcolumn',
+                width: 40,
+                widget: {
+                    xtype: 'button',
+                    tooltip: gettext('Delete'),
+                    handler: 'deleteRedistribution',
+                    iconCls: 'fa fa-trash-o',
+                },
             },
         ];
 
-- 
2.47.3

[PATCH manager 3/3] ui: sdn: fabrics: make name required for new fabrics

[Dominik Csapak]

It's required in the backend, make it required in the GUI too.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/sdn/fabrics/FabricEdit.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/manager6/sdn/fabrics/FabricEdit.js b/www/manager6/sdn/fabrics/FabricEdit.js
index 322a62c0..46c8dd6b 100644
--- a/www/manager6/sdn/fabrics/FabricEdit.js
+++ b/www/manager6/sdn/fabrics/FabricEdit.js
@@ -29,6 +29,7 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', {
             fieldLabel: gettext('Name'),
             labelWidth: 120,
             maxLength: 8,
+            allowBlank: false,
             name: 'id',
             cbind: {
                 disabled: '{!isCreate}',
-- 
2.47.3

applied: [PATCH manager 1/3] ui: sdn: interface panel: limit heigh

[Thomas Lamprecht]

On Wed, 20 May 2026 10:10:40 +0200, Dominik Csapak wrote:
> so that in the case a node has many network interface, it can still be
> used on smaller screens. Without that limit the edit window may grow
> beyond the viewport.

Applied, thanks!

[1/3] ui: sdn: interface panel: limit heigh
      commit: b2c69cee65ce84640fafcdd2b769bd1f78e7cf58
[2/3] ui: sdn: redistribution grid: make style consistent
      commit: bdf683e5c2c6fe8faf1bab37b7fe68fb69771375
[3/3] ui: sdn: fabrics: make name required for new fabrics
      commit: 5b4f9f4d177776b814b8bcd8043d55dcc0384c3c