all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Gabriel Goller <g.goller@proxmox.com>
Subject: applied: [PATCH proxmox] network-types: stricter HostnameOrIpAddr parsing
Date: Wed, 20 May 2026 04:40:19 +0200	[thread overview]
Message-ID: <177924480524.3422753.11604076563491621040.b4-ty@b4> (raw)
In-Reply-To: <20260519191406.293932-1-g.goller@proxmox.com>

On Tue, 19 May 2026 21:14:04 +0200, Gabriel Goller wrote:
> Previously the HostnameOrIpAddr struct had a String as hostname, so
> everything that wasn't an ip was automatically a hostname. This was
> weird because it didn't fail on e.g. a prefix, which resultet in the
> "2001:1::/64:3000" wireguard config entries. In order to catch these
> common errors and make everything a bit tighter, validate hostnames
> correctly (only alphanumeric and hyphens, according to the rfc).
> 
> [...]

Applied, thanks!

[1/1] network-types: stricter HostnameOrIpAddr parsing
      commit: 197e6083eb45632782f4c7046bb8416bc4fff405




      reply	other threads:[~2026-05-20  2:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19 19:14 [PATCH proxmox] network-types: stricter HostnameOrIpAddr parsing Gabriel Goller
2026-05-20  2:40 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177924480524.3422753.11604076563491621040.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal