From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 961A51FF13B for ; Wed, 20 May 2026 04:41:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 30ABD146F2; Wed, 20 May 2026 04:41:34 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Gabriel Goller Subject: applied: [PATCH proxmox] network-types: stricter HostnameOrIpAddr parsing Date: Wed, 20 May 2026 04:40:19 +0200 Message-ID: <177924480524.3422753.11604076563491621040.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260519191406.293932-1-g.goller@proxmox.com> References: <20260519191406.293932-1-g.goller@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779244845530 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.296 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy ENA_SUBJ_ODD_CASE 2.6 Subject has odd case KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: F5ACY5R2QEXBBVCRQ4N76T4F7SNH3FWM X-Message-ID-Hash: F5ACY5R2QEXBBVCRQ4N76T4F7SNH3FWM X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 19 May 2026 21:14:04 +0200, Gabriel Goller wrote: > Previously the HostnameOrIpAddr struct had a String as hostname, so > everything that wasn't an ip was automatically a hostname. This was > weird because it didn't fail on e.g. a prefix, which resultet in the > "2001:1::/64:3000" wireguard config entries. In order to catch these > common errors and make everything a bit tighter, validate hostnames > correctly (only alphanumeric and hyphens, according to the rfc). > > [...] Applied, thanks! [1/1] network-types: stricter HostnameOrIpAddr parsing commit: 197e6083eb45632782f4c7046bb8416bc4fff405