Re: [PATCH datacenter-manager v3 04/12] subscription: api: add key pool and node status endpoints

[Wolfgang Bumiller <w.bumiller@proxmox.com>]

On Fri, 15 May 2026 09:43:14 +0200, Thomas Lamprecht <t.lamprecht@proxmox.com> wrote:
> diff --git a/server/src/api/subscriptions/mod.rs b/server/src/api/subscriptions/mod.rs
> new file mode 100644
> index 0000000..aa3146e
> --- /dev/null
> +++ b/server/src/api/subscriptions/mod.rs
> @@ -0,0 +1,1542 @@
> [ ... skip 210 lines ... ]
> +        // loop on the first collision. The all-or-nothing contract holds because save_config
> +        // only runs after the loop completes, so a bail on entry N leaves the on-disk pool
> +        // untouched even if entries 1..N already landed in the in-memory `config`.
> +        for entry in entries {
> +            let key = entry.key.clone();
> +            if let Some(existing) = config.insert(key.clone(), entry) {

^ This clone can be skipped, since you use the key from `existing` for
the error message.

> [ ... skip 34 lines ... ]
> +    let (config, digest) = pdm_config::subscriptions::config()?;
> +    rpcenv["digest"] = digest.to_hex().into();
> +    let mut entry = config
> +        .get(&key)
> +        .cloned()
> +        .ok_or_else(|| http_err!(NOT_FOUND, "key '{key}' not found in pool"))?;

We could put the `http_err!()` call into a reusable closure so we also
only have a single instance of the message text, to make it more
difficult for future patches to accidentally only change 1 of them.

--