Re: [PATCH datacenter-manager v3 02/12] pdm-client: add wait_for_local_task helper

[Wolfgang Bumiller <w.bumiller@proxmox.com>]

On Fri, 15 May 2026 09:43:12 +0200, Thomas Lamprecht <t.lamprecht@proxmox.com> wrote:
> diff --git a/lib/pdm-client/src/lib.rs b/lib/pdm-client/src/lib.rs
> index 76b33ef..cb5bb04 100644
> --- a/lib/pdm-client/src/lib.rs
> +++ b/lib/pdm-client/src/lib.rs
> @@ -890,6 +890,36 @@ impl<T: HttpApiClient> PdmClient<T> {
> [ ... skip 20 lines ... ]
> +            let body: Value = self.0.get(&path).await?.expect_json()?.data;
> +            let running = body
> +                .get("status")
> +                .and_then(Value::as_str)
> +                .map(|s| s == "running")
> +                .unwrap_or(false);

Minor nit:
The last 3 lines could be condensed to
    == Some("running")
which is slightly easier to read, and even makes it short enough to fit
within `if` and `{`.

Also, since `body` is already a `Value`, it's safe to just index it. If
it is not a map, it'll just give you a `Null`, and it does the same if
it is a map but the key does not exist. This means we could call
`.as_str()` without needing `.and_then()`, so the entire check could be:

    if body["running"].as_str() == Some("running") {
        ...
    }

See the indexing docs here[1]

[1] https://docs.rs/serde_json/latest/serde_json/enum.Value.html#method.get

--