all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dietmar Maurer <dietmar@proxmox.com>
To: "Proxmox Backup Server development discussion"
	<pbs-devel@lists.proxmox.com>,
	"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] fix #2978: allow non-root to view datastore usage
Date: Fri, 4 Sep 2020 06:19:15 +0200 (CEST)	[thread overview]
Message-ID: <1778747894.712.1599193156040@webmail.proxmox.com> (raw)
In-Reply-To: <20200903124922.3386277-1-f.gruenbichler@proxmox.com>

applied

> On 09/03/2020 2:49 PM Fabian Grünbichler <f.gruenbichler@proxmox.com> wrote:
> 
>  
> for datastores where the requesting user has read or write permissions,
> since the API method itself filters by that already. this is the same
> permission setting and filtering that the datastore list API endpoint
> does.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
>  src/api2/status.rs | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/api2/status.rs b/src/api2/status.rs
> index c44e73f1..10ae8b3d 100644
> --- a/src/api2/status.rs
> +++ b/src/api2/status.rs
> @@ -74,6 +74,9 @@ use crate::config::acl::{
>              },
>          },
>      },
> +    access: {
> +        permission: &Permission::Anybody,
> +    },
>  )]
>  /// List Datastore usages and estimates
>  fn datastore_status(
> -- 
> 2.20.1
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel




      reply	other threads:[~2020-09-04  4:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-03 12:49 [pbs-devel] " Fabian Grünbichler
2020-09-04  4:19 ` Dietmar Maurer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1778747894.712.1599193156040@webmail.proxmox.com \
    --to=dietmar@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal