From: Lukas Wagner <l.wagner@proxmox.com>
To: pdm-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com>
Subject: applied: [PATCH datacenter-manager] ui: views: correctly set filter values on edit
Date: Mon, 27 Apr 2026 10:03:19 +0200 [thread overview]
Message-ID: <177727699997.42107.3522092323336021534.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260421120002.2411373-1-d.csapak@proxmox.com>
On Tue, 21 Apr 2026 13:59:56 +0200, Dominik Csapak wrote:
> There were two issues here:
>
> * use of 'default' instead of 'value': this triggered an unnecessary
> change and did not properly track the value for reset
>
> * change of the filter even if the old type was the same. This lead
> to a change from e.g. "remote:foo" to "remote:" which overwrote
> the filter value with an empty string. This happens on reset, when the
> type was changed, as we force the value to the original one which
> triggers an on_change.
>
> [...]
Applied, thanks!
[1/1] ui: views: correctly set filter values on edit
commit: 2aa9f38a4d5cbacfb677a6980ff03a7bf7997d49
Best regards,
--
Lukas Wagner <l.wagner@proxmox.com>
prev parent reply other threads:[~2026-04-27 8:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 11:59 [PATCH datacenter-manager] ui: views: correctly set filter values on edit Dominik Csapak
2026-04-27 8:03 ` Lukas Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177727699997.42107.3522092323336021534.b4-ty@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.