From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 406F31FF16B for ; Mon, 27 Apr 2026 10:04:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 10B9F1420D; Mon, 27 Apr 2026 10:04:16 +0200 (CEST) From: Lukas Wagner To: pdm-devel@lists.proxmox.com, Dominik Csapak In-Reply-To: <20260421120002.2411373-1-d.csapak@proxmox.com> References: <20260421120002.2411373-1-d.csapak@proxmox.com> Subject: applied: [PATCH datacenter-manager] ui: views: correctly set filter values on edit Message-Id: <177727699997.42107.3522092323336021534.b4-ty@proxmox.com> Date: Mon, 27 Apr 2026 10:03:19 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777276956313 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: K6HG4WYMXHM2GXQF2B6ALYWZHM6SHP3A X-Message-ID-Hash: K6HG4WYMXHM2GXQF2B6ALYWZHM6SHP3A X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 21 Apr 2026 13:59:56 +0200, Dominik Csapak wrote: > There were two issues here: > > * use of 'default' instead of 'value': this triggered an unnecessary > change and did not properly track the value for reset > > * change of the filter even if the old type was the same. This lead > to a change from e.g. "remote:foo" to "remote:" which overwrote > the filter value with an empty string. This happens on reset, when the > type was changed, as we force the value to the original one which > triggers an on_change. > > [...] Applied, thanks! [1/1] ui: views: correctly set filter values on edit commit: 2aa9f38a4d5cbacfb677a6980ff03a7bf7997d49 Best regards, -- Lukas Wagner