From: Dietmar Maurer <dietmar@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v2] api2/reader: asyncify the reader worker task
Date: Fri, 29 Jan 2021 09:17:51 +0100 (CET) [thread overview]
Message-ID: <1776986966.1276.1611908272501@webmail.proxmox.com> (raw)
In-Reply-To: <5fc24404-3cbb-71ca-a2a4-c989281b85c2@proxmox.com>
> On 01/29/2021 8:01 AM Dominik Csapak <d.csapak@proxmox.com> wrote:
>
>
> On 1/29/21 7:05 AM, Dietmar Maurer wrote:
> > Why did you change the _guard lifetime?
>
> how so?
>
> before this patch the guard was moved to the 'map' closure of
> the future::select call
> so it did go out of scope after either future (req_fut, abort_future)
> resolved
>
> now i moved it in the async move block of the worker, and goes out of
> scope after the future resolves
OK, I can see it now - will apply the patch.
prev parent reply other threads:[~2021-01-29 8:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 10:17 Dominik Csapak
2021-01-29 6:05 ` Dietmar Maurer
2021-01-29 7:01 ` Dominik Csapak
2021-01-29 8:17 ` Dietmar Maurer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1776986966.1276.1611908272501@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.