all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Gabriel Goller <g.goller@proxmox.com>,
	Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: applied: [PATCH manager/network/proxmox{-ve-rs,-perl-rs} v8 00/21] Generate frr config using jinja templates and rust types
Date: Tue, 07 Apr 2026 11:56:26 +0200	[thread overview]
Message-ID: <1775555676.7m5ulveesz.astroid@yuna.none> (raw)
In-Reply-To: <w2a5wr437jgnib4ggxwb6avn5ty7oqrcxs7ystjmtjj3kbyhme@o7ujlsxw7ao4>

On March 31, 2026 10:44 am, Gabriel Goller wrote:
> On 31.03.2026 10:35, Thomas Lamprecht wrote:
>> Am 31.03.26 um 10:28 schrieb Gabriel Goller:
>> > Note that patch 10 is still in the approval queue!
>> 
>> ah true, let it through now; I had in mind that there was a discussion for
>> skipping the vtysh test for now (or maybe Wolfgang just mentioned something
>> offlist), so I did not miss it.
> 
> Hmm yeah I added it with v7 (I think), but afaics wolfgang reviewed it, so I
> thought we can pull it in.
> 
> @Fabian maybe as well.

via debcargo, anything requiring dev-deps will be moved to autopkgtests
(which sbuild can run automatically post-build). if we go down that
route, we need to ensure to really run those tests when building
packages!




      reply	other threads:[~2026-04-07  9:56 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-27 15:01 Gabriel Goller
2026-03-27 15:01 ` [PATCH proxmox-ve-rs v8 01/21] ve-config: firewall: cargo fmt Gabriel Goller
2026-03-27 15:01 ` [PATCH proxmox-ve-rs v8 02/21] frr: add proxmox-frr-templates package that contains templates Gabriel Goller
2026-03-27 15:01 ` [PATCH proxmox-ve-rs v8 03/21] ve-config: remove FrrConfigBuilder struct Gabriel Goller
2026-03-27 15:01 ` [PATCH proxmox-ve-rs v8 04/21] sdn-types: support variable-length NET identifier Gabriel Goller
2026-03-27 15:01 ` [PATCH proxmox-ve-rs v8 05/21] frr: add template serializer and serialize fabrics using templates Gabriel Goller
2026-03-27 15:01 ` [PATCH proxmox-ve-rs v8 06/21] frr: add isis configuration and templates Gabriel Goller
2026-03-27 15:01 ` [PATCH proxmox-ve-rs v8 07/21] frr: support custom frr configuration lines Gabriel Goller
2026-03-27 15:01 ` [PATCH proxmox-ve-rs v8 08/21] frr: add bgp support with templates and serialization Gabriel Goller
2026-03-27 15:01 ` [PATCH proxmox-ve-rs v8 09/21] frr: enable minijinja strict undefined behavior mode Gabriel Goller
2026-03-27 15:01 ` [PATCH proxmox-ve-rs v8 10/21] frr: add vtysh integration tests for proxmox-frr Gabriel Goller
2026-03-27 15:01 ` [PATCH proxmox-perl-rs v8 11/21] sdn: add function to generate the frr config for all daemons Gabriel Goller
2026-03-27 15:01 ` [PATCH pve-network v8 12/21] tests: use Test::Differences to make test assertions Gabriel Goller
2026-03-27 15:01 ` [PATCH pve-network v8 13/21] test: add tests for frr.conf.local merging Gabriel Goller
2026-03-27 15:01 ` [PATCH pve-network v8 14/21] test: bgp: add some various integration tests Gabriel Goller
2026-03-27 15:01 ` [PATCH pve-network v8 15/21] sdn: write structured frr config that can be rendered using templates Gabriel Goller
2026-03-27 15:01 ` [PATCH pve-network v8 16/21] sdn: remove duplicate comment line '!' in frr config Gabriel Goller
2026-03-27 15:01 ` [PATCH pve-network v8 17/21] tests: rearrange some statements in the " Gabriel Goller
2026-03-27 15:01 ` [PATCH pve-network v8 18/21] sdn: adjust frr.conf.local merging to rust template types Gabriel Goller
2026-03-27 15:01 ` [PATCH pve-network v8 19/21] test: adjust frr_local_merge test for new template generation Gabriel Goller
2026-03-27 15:01 ` [PATCH pve-network v8 20/21] api: add dry-run endpoint for sdn apply to preview changes Gabriel Goller
2026-03-27 15:01 ` [PATCH pve-manager v8 21/21] sdn: add dry-run diff view for sdn apply Gabriel Goller
2026-03-28 20:19   ` Thomas Lamprecht
2026-03-30 12:04     ` Gabriel Goller
2026-03-28 16:55 ` applied: [PATCH manager/network/proxmox{-ve-rs,-perl-rs} v8 00/21] Generate frr config using jinja templates and rust types Thomas Lamprecht
2026-03-31  8:29   ` Gabriel Goller
2026-03-31  8:35     ` Thomas Lamprecht
2026-03-31  8:44       ` Gabriel Goller
2026-04-07  9:56         ` Fabian Grünbichler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1775555676.7m5ulveesz.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal