all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: yew-devel@lists.proxmox.com, Shannon Sterz <s.sterz@proxmox.com>
Subject: applied: [PATCH yew-comp] auth view: don't mark realm sync dialog as "edit" and set submit text
Date: Thu,  2 Apr 2026 13:05:05 +0200	[thread overview]
Message-ID: <177512788453.2173353.5505131659450818433.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260325114334.137252-2-s.sterz@proxmox.com>

On Wed, 25 Mar 2026 12:43:35 +0100, Shannon Sterz wrote:
> previously it was not possible to submit this window without making
> any changes since setting a loader marked the window as being in "edit
> mode". leading to the paradoxical scenario where running a sync job
> with the default settings for that realm wasn't possible.
> 
> change this behaviour by marking the `EditWindow` as not being in
> "edit mode" and setting a more appropriate text for the submit button.
> the side-effect of this is that the reset button is no longer
> available, but that is deemed preferable over not being able to sync
> with a realm's default configuration.
> 
> [...]

Applied, thanks!

[1/1] auth view: don't mark realm sync dialog as "edit" and set submit text
      commit: 50abe35a311aea36fd2eb88e4fefdf572c2e50f9




      reply	other threads:[~2026-04-02 11:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-25 11:43 Shannon Sterz
2026-04-02 11:05 ` Dominik Csapak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177512788453.2173353.5505131659450818433.b4-ty@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=s.sterz@proxmox.com \
    --cc=yew-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal