From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Kefu Chai <k.chai@proxmox.com>
Subject: applied: [PATCH v2 proxmox-acme 0/3] update acme.sh DNS API to upstream 3.1.2 tag
Date: Tue, 31 Mar 2026 18:48:59 +0200 [thread overview]
Message-ID: <177497573036.62091.13375041597682803558.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260331071041.1199091-1-k.chai@proxmox.com>
On Tue, 31 Mar 2026 15:10:38 +0800, Kefu Chai wrote:
> Changes since v1:
> - Fix missing Makefile ACME_SOURCES entries for the new plugins; without
> this they were registered in the schema but not installed by the package
> - Add test/verify-acme-sources-in-makefile.pl to catch this class of
> error: cross-checks dnsapi/ scripts in the submodule against the
> Makefile install list, with ACME_SOURCES passed via Make so no
> Makefile parsing is needed in Perl
> - Hook the tests into dpkg-buildpackage via override_dh_auto_test so
> they run automatically on every package build
>
> [...]
Applied, adapted the second one to parse the Makefile directly though, IMO not
that fragile as the list format is simple and under our control, thanks!
[1/3] update acme.sh DNS API to upstream 3.1.2 tag
commit: c61e42a68a829f79f1c60dee7b504aad217e43b5
[2/3] tests: verify all dnsapi plugins are listed in Makefile ACME_SOURCES
commit: c362090b0b49f8b0b0f2a7cedae52e909560eecd
[3/3] buildsys: run tests as part of dpkg-buildpackage
SKIPPED
prev parent reply other threads:[~2026-03-31 16:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 7:10 Kefu Chai
2026-03-31 7:10 ` [PATCH v2 proxmox-acme 1/3] " Kefu Chai
2026-03-31 7:10 ` [PATCH v2 proxmox-acme 2/3] tests: verify all dnsapi plugins are listed in Makefile ACME_SOURCES Kefu Chai
2026-03-31 7:10 ` [PATCH v2 proxmox-acme 3/3] buildsys: run tests as part of dpkg-buildpackage Kefu Chai
2026-03-31 16:16 ` Thomas Lamprecht
2026-04-01 4:31 ` Kefu Chai
2026-03-31 16:48 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177497573036.62091.13375041597682803558.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=k.chai@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.