all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH proxmox-perltidy] use more explicit --cuddled-blocks rather than --cuddled-else
@ 2026-03-27 13:17 Fiona Ebner
  2026-03-30 10:45 ` applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Fiona Ebner @ 2026-03-27 13:17 UTC (permalink / raw)
  To: pve-devel

The --cuddled-else flag is equivalent to --cuddled-blocks, but might
wrongly suggest that it only applies to else (and elsif). While those
are the most relevant ones for the Proxmox codebases, there are a few
other ones (see 'man perltidy'). Using --cuddled-blocks also better
suggests that the --cuddled-block-list option is a modifier that only
takes effect when --cuddled-blocks itself is present.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/perltidyrc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/perltidyrc b/src/perltidyrc
index 300cf81..4299f29 100644
--- a/src/perltidyrc
+++ b/src/perltidyrc
@@ -70,7 +70,7 @@
 --maximum-consecutive-blank-lines=1 # hard-code the default
 
 # Control structure formatting
---cuddled-else # avoid extra line for else
+--cuddled-blocks # avoid extra line for else, elsif, ...
 --cuddled-block-list=sort,map,grep # also cuddle sort, map and grep over standard else/elsif/...
 
 --keyword-group-blanks-inside
-- 
2.47.3





^ permalink raw reply	[flat|nested] 2+ messages in thread

* applied: [PATCH proxmox-perltidy] use more explicit --cuddled-blocks rather than --cuddled-else
  2026-03-27 13:17 [PATCH proxmox-perltidy] use more explicit --cuddled-blocks rather than --cuddled-else Fiona Ebner
@ 2026-03-30 10:45 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2026-03-30 10:45 UTC (permalink / raw)
  To: pve-devel, Fiona Ebner

On Fri, 27 Mar 2026 14:17:08 +0100, Fiona Ebner wrote:
> The --cuddled-else flag is equivalent to --cuddled-blocks, but might
> wrongly suggest that it only applies to else (and elsif). While those
> are the most relevant ones for the Proxmox codebases, there are a few
> other ones (see 'man perltidy'). Using --cuddled-blocks also better
> suggests that the --cuddled-block-list option is a modifier that only
> takes effect when --cuddled-blocks itself is present.
> 
> [...]

Applied, thanks!

[1/1] use more explicit --cuddled-blocks rather than --cuddled-else
      commit: 87fd746b7e083021dfe9bb7801931bf74b436464




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-03-30 10:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-27 13:17 [PATCH proxmox-perltidy] use more explicit --cuddled-blocks rather than --cuddled-else Fiona Ebner
2026-03-30 10:45 ` applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal