Re: [PATCH proxmox-backup 5/5] api: set default fstrim schedule on datastore create

Re: [PATCH proxmox-backup 5/5] api: set default fstrim schedule on datastore create

[Fabian Grünbichler]

On March 19, 2026 3:36 pm, Christian Ebner wrote:
> Default to set a weekly fstrim schedule for newly created datastores.
> 
> Do not set when crating a datastore via the ZFS dialog, as it does
> not support discard.

that is not true, it just doesn't support triggering discard/trim via
fstrim.. which might be true for other file systems as well, not sure?

> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
>  src/api2/config/datastore.rs     | 1 +
>  src/api2/node/disks/directory.rs | 6 ++++--
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/src/api2/config/datastore.rs b/src/api2/config/datastore.rs
> index b10b7fb0a..45df53c72 100644
> --- a/src/api2/config/datastore.rs
> +++ b/src/api2/config/datastore.rs
> @@ -336,6 +336,7 @@ pub fn create_datastore(
>      // clearing prune settings in the datastore config, as they are now handled by prune jobs
>      let config = DataStoreConfig {
>          prune_schedule: None,
> +        fstrim_schedule: config.fstrim_schedule.or(Some("weekly".to_string())),
>          keep: KeepOptions::default(),
>          ..config
>      };
> diff --git a/src/api2/node/disks/directory.rs b/src/api2/node/disks/directory.rs
> index c37d65b8d..42cd1d2d7 100644
> --- a/src/api2/node/disks/directory.rs
> +++ b/src/api2/node/disks/directory.rs
> @@ -242,10 +242,12 @@ pub fn create_datastore_disk(
>                  let lock = pbs_config::datastore::lock_config()?;
>                  let datastore: DataStoreConfig = if removable_datastore {
>                      serde_json::from_value(
> -                        json!({ "name": name, "path": name, "backing-device": uuid }),
> +                        json!({ "name": name, "path": name, "backing-device": uuid , "fstrim-schedule": "weekly" }),
>                      )?
>                  } else {
> -                    serde_json::from_value(json!({ "name": name, "path": mount_point }))?
> +                    serde_json::from_value(
> +                        json!({ "name": name, "path": mount_point, "fstrim-schedule": "weekly" }),
> +                    )?
>                  };
>                  let (config, _digest) = pbs_config::datastore::config()?;
>  
> -- 
> 2.47.3
> 
> 
> 
> 
> 
> 

[PATCH proxmox-backup 5/5] api: set default fstrim schedule on datastore create

[Christian Ebner]

Default to set a weekly fstrim schedule for newly created datastores.

Do not set when crating a datastore via the ZFS dialog, as it does
not support discard.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 src/api2/config/datastore.rs     | 1 +
 src/api2/node/disks/directory.rs | 6 ++++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/api2/config/datastore.rs b/src/api2/config/datastore.rs
index b10b7fb0a..45df53c72 100644
--- a/src/api2/config/datastore.rs
+++ b/src/api2/config/datastore.rs
@@ -336,6 +336,7 @@ pub fn create_datastore(
     // clearing prune settings in the datastore config, as they are now handled by prune jobs
     let config = DataStoreConfig {
         prune_schedule: None,
+        fstrim_schedule: config.fstrim_schedule.or(Some("weekly".to_string())),
         keep: KeepOptions::default(),
         ..config
     };
diff --git a/src/api2/node/disks/directory.rs b/src/api2/node/disks/directory.rs
index c37d65b8d..42cd1d2d7 100644
--- a/src/api2/node/disks/directory.rs
+++ b/src/api2/node/disks/directory.rs
@@ -242,10 +242,12 @@ pub fn create_datastore_disk(
                 let lock = pbs_config::datastore::lock_config()?;
                 let datastore: DataStoreConfig = if removable_datastore {
                     serde_json::from_value(
-                        json!({ "name": name, "path": name, "backing-device": uuid }),
+                        json!({ "name": name, "path": name, "backing-device": uuid , "fstrim-schedule": "weekly" }),
                     )?
                 } else {
-                    serde_json::from_value(json!({ "name": name, "path": mount_point }))?
+                    serde_json::from_value(
+                        json!({ "name": name, "path": mount_point, "fstrim-schedule": "weekly" }),
+                    )?
                 };
                 let (config, _digest) = pbs_config::datastore::config()?;
 
-- 
2.47.3