[PATCH pve-manager v3 0/2] fix #7300: acl path include pre-generated zones and fabrics

[PATCH pve-manager v3 0/2] fix #7300: acl path include pre-generated zones and fabrics

[David Riley]

Thanks for the feedback.

Differences from v2:
* moved var to let conversion to a seperate commit
* using record.get instead of direct data access

Differences from v1:
* Add signature 

David Riley (2):
  ui: replace var with let
  fix #7300: acl path include pre-generated zones and fabrics

 www/manager6/data/PermPathStore.js | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

-- 
2.47.3

[PATCH pve-manager v3 1/2] ui: replace var with let

[David Riley]

Signed-off-by: David Riley <d.riley@proxmox.com>
---

Notes:
    Differences from v2:
    * moved var to let conversion to a seperate commit
    
    Differences from v1:
    * Add signature

 www/manager6/data/PermPathStore.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/data/PermPathStore.js b/www/manager6/data/PermPathStore.js
index c7ec4231..0a98846b 100644
--- a/www/manager6/data/PermPathStore.js
+++ b/www/manager6/data/PermPathStore.js
@@ -22,7 +22,7 @@ Ext.define('PVE.data.PermPathStore', {
     ],
 
     constructor: function (config) {
-        var me = this;
+        let me = this;
 
         config = config || {};
 
-- 
2.47.3

[PATCH pve-manager v3 2/2] fix #7300: acl path include pre-generated zones and fabrics

[David Riley]

Permission Path selection will show:
'/sdn/zones/<zone>'
'/sdn/fabrics/<fabric>'

The case 'network' is used because this will act as the top-level
resource for all networking entities (including SDN).

see: https://git.proxmox.com/?p=pve-manager.git;a=commit;h=9ac04d9572a458aeb891feb9b695d793cf7b122d
Signed-off-by: David Riley <d.riley@proxmox.com>
---

Notes:
    Differences from v2:
    * using record.get instead of direct data access
    
    Differences from v1:
    * Add signature

 www/manager6/data/PermPathStore.js | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/www/manager6/data/PermPathStore.js b/www/manager6/data/PermPathStore.js
index 0a98846b..33e4cb21 100644
--- a/www/manager6/data/PermPathStore.js
+++ b/www/manager6/data/PermPathStore.js
@@ -36,6 +36,9 @@ Ext.define('PVE.data.PermPathStore', {
                 case 'node':
                     path = '/nodes/' + record.get('text');
                     break;
+                case 'network':
+                    path = '/sdn/' + record.get('network-type') + 's/' + record.get('network');
+                    break;
                 case 'qemu':
                     path = '/vms/' + record.get('vmid');
                     break;
-- 
2.47.3

applied: [PATCH pve-manager v3 0/2] fix #7300: acl path include pre-generated zones and fabrics

[Thomas Lamprecht]

On Fri, 13 Mar 2026 13:26:00 +0100, David Riley wrote:
> Thanks for the feedback.
> 
> Differences from v2:
> * moved var to let conversion to a seperate commit
> * using record.get instead of direct data access
> 
> Differences from v1:
> * Add signature
> 
> [...]

Applied, thanks!

But I expanded/reworked the commit messages a bit to provide further rationale,
no worries, for a first series this was pretty good already, but maybe check
out the changes I made to see what you could maybe do different/improve for a
next series. If you got any questions here (or have remarks for my changes),
feel encouraged to just ask directly.

[1/2] ui: replace var with let
      commit: 0c015d0ca2ae093a8db70e7fc97a254d71609788
[2/2] fix #7300: acl path include pre-generated zones and fabrics
      commit: 3aefa09998a51f955537568af59b6e851cc6d063