all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com,
	Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: applied: [PATCH manager v2 0/7] ui: qga: add checkbox for guest-fsfreeze
Date: Mon, 16 Mar 2026 16:29:55 +0100	[thread overview]
Message-ID: <177367498978.160217.14014950858139795236.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260313095534.79526-1-m.sandoval@proxmox.com>

On Fri, 13 Mar 2026 10:55:26 +0100, Maximiliano Sandoval wrote:
> Something that was missing from Fiona's comments was giving the "hint"
> CSS class to the "Deprecated" part of the old checkbox's label. I was
> not sure how to make that work in ExtJS.
> 
> The migration would work as follows:
> 
>  - The new key takes preference over the old one so using the old one is OK.
>  - If the key is in the config file and explicitly disabled then the old
>    checkbox would be displayed
>  - But we delete the deprecated key from the config if it was explicitly
>    enabled (it is the default) after performing any change
> 
> [...]

Applied, thanks!

[1/7] ui: utils: support guest-fsfreeze at render_qga_features
      commit: 53a4f7dbd52af88d1f69cf98b87d6a7add216ee3
[2/7] ui: qga: merge translatable string
      commit: b6386e6da8bc2ce1b73610378f82a2948ecbba5a
[3/7] ui: qga: move freeze-fs-on-backup to advanced opts
      commit: 7a3c96a6961c926ada94c3922b0f40ce167c0d81
[4/7] ui: qga: note that freeze-fs-on-backup is deprecated
      commit: 3aff7440bdf2f0a60a4bef1ba32a7771e709233a
[5/7] ui: qga: add checkbox for guest-fsfreeze
      commit: b13cdbf908271bed675678cdf72bc5fcf72c295d
[6/7] ui: qga: call parameter me instead of this
      commit: a0a4be2c06349ab3b498d797c670b9c45746b89d
[7/7] ui: qga: hide freeze-fs-on-backup conditionally
      commit: 630ac0318b5e7c8c3b2574566ae4230e31f2bec6




      parent reply	other threads:[~2026-03-16 15:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13  9:55 Maximiliano Sandoval
2026-03-13  9:55 ` [PATCH manager v2 1/7] ui: utils: support guest-fsfreeze at render_qga_features Maximiliano Sandoval
2026-03-13  9:55 ` [PATCH manager v2 2/7] ui: qga: merge translatable string Maximiliano Sandoval
2026-03-13  9:55 ` [PATCH manager v2 3/7] ui: qga: move freeze-fs-on-backup to advanced opts Maximiliano Sandoval
2026-03-13  9:55 ` [PATCH manager v2 4/7] ui: qga: note that freeze-fs-on-backup is deprecated Maximiliano Sandoval
2026-03-13  9:55 ` [PATCH manager v2 5/7] ui: qga: add checkbox for guest-fsfreeze Maximiliano Sandoval
2026-03-16 21:41   ` Thomas Lamprecht
2026-03-13  9:55 ` [PATCH manager v2 6/7] ui: qga: call parameter me instead of this Maximiliano Sandoval
2026-03-13  9:55 ` [PATCH manager v2 7/7] ui: qga: hide freeze-fs-on-backup conditionally Maximiliano Sandoval
2026-03-16 21:37   ` Thomas Lamprecht
2026-03-16 15:29 ` Fiona Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=177367498978.160217.14014950858139795236.b4-ty@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal