From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pbs-devel@lists.proxmox.com, Hannes Laimer <h.laimer@proxmox.com>
Subject: applied: [PATCH proxmox] s3-client: fix double URI encoding of copy_object destination key
Date: Thu, 5 Mar 2026 09:37:19 +0100 [thread overview]
Message-ID: <177269983696.204911.10697586925220963091.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260304095514.27118-1-h.laimer@proxmox.com>
On Wed, 04 Mar 2026 10:55:14 +0100, Hannes Laimer wrote:
> build_uri() already calls aws_sign_v4_uri_encode() on its path argument,
> so pre-encoding the destination key in copy_object() caused characters
> like ':' to be encoded twice ('%3A' -> '%253A'). The server decodes the
> URL path once, leaving '%3A' literally in the stored object key instead
> of ':'.
>
> The copy source header still requires explicit encoding since it is not
> routed through build_uri().
>
> [...]
Applied, thanks!
[1/1] s3-client: fix double URI encoding of copy_object destination key
commit: 331013a3f8821f83fb4463a59c7229b2bb756cf3
Best regards,
--
Fabian Grünbichler <f.gruenbichler@proxmox.com>
prev parent reply other threads:[~2026-03-05 8:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 9:55 Hannes Laimer
2026-03-04 10:16 ` Christian Ebner
2026-03-05 8:37 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177269983696.204911.10697586925220963091.b4-ty@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.