all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH manager] ui: mark Key and Value as translatable
@ 2026-02-24 14:15 Maximiliano Sandoval
  2026-02-25 13:44 ` applied: " Dominik Csapak
  0 siblings, 1 reply; 2+ messages in thread
From: Maximiliano Sandoval @ 2026-02-24 14:15 UTC (permalink / raw)
  To: pve-devel

These are seen on the Summary when creating a VM or container.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---

Quickly tested on a VM.

 www/manager6/lxc/CreateWizard.js   | 4 ++--
 www/manager6/qemu/CreateWizard.js  | 4 ++--
 www/manager6/window/GuestImport.js | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/www/manager6/lxc/CreateWizard.js b/www/manager6/lxc/CreateWizard.js
index 46835e7a..bba194b4 100644
--- a/www/manager6/lxc/CreateWizard.js
+++ b/www/manager6/lxc/CreateWizard.js
@@ -275,8 +275,8 @@ Ext.define('PVE.lxc.CreateWizard', {
                         ],
                     },
                     columns: [
-                        { header: 'Key', width: 150, dataIndex: 'key' },
-                        { header: 'Value', flex: 1, dataIndex: 'value', renderer: Ext.htmlEncode },
+                        { header: gettext('Key'), width: 150, dataIndex: 'key' },
+                        { header: gettext('Value'), flex: 1, dataIndex: 'value', renderer: Ext.htmlEncode },
                     ],
                 },
             ],
diff --git a/www/manager6/qemu/CreateWizard.js b/www/manager6/qemu/CreateWizard.js
index 341324c8..145be534 100644
--- a/www/manager6/qemu/CreateWizard.js
+++ b/www/manager6/qemu/CreateWizard.js
@@ -255,8 +255,8 @@ Ext.define('PVE.qemu.CreateWizard', {
                         ],
                     },
                     columns: [
-                        { header: 'Key', width: 150, dataIndex: 'key' },
-                        { header: 'Value', flex: 1, dataIndex: 'value', renderer: Ext.htmlEncode },
+                        { header: gettext('Key'), width: 150, dataIndex: 'key' },
+                        { header: gettext('Value'), flex: 1, dataIndex: 'value', renderer: Ext.htmlEncode },
                     ],
                 },
             ],
diff --git a/www/manager6/window/GuestImport.js b/www/manager6/window/GuestImport.js
index 3e7fff39..9c9b0f1b 100644
--- a/www/manager6/window/GuestImport.js
+++ b/www/manager6/window/GuestImport.js
@@ -965,8 +965,8 @@ Ext.define('PVE.window.GuestImport', {
                                 ],
                             },
                             columns: [
-                                { header: 'Key', width: 150, dataIndex: 'key' },
-                                { header: 'Value', flex: 1, dataIndex: 'value' },
+                                { header: gettext('Key'), width: 150, dataIndex: 'key' },
+                                { header: gettext('Value'), flex: 1, dataIndex: 'value' },
                             ],
                         },
                     ],
-- 
2.47.3





^ permalink raw reply	[flat|nested] 2+ messages in thread

* applied: [PATCH manager] ui: mark Key and Value as translatable
  2026-02-24 14:15 [PATCH manager] ui: mark Key and Value as translatable Maximiliano Sandoval
@ 2026-02-25 13:44 ` Dominik Csapak
  0 siblings, 0 replies; 2+ messages in thread
From: Dominik Csapak @ 2026-02-25 13:44 UTC (permalink / raw)
  To: pve-devel, Maximiliano Sandoval

On Tue, 24 Feb 2026 15:15:19 +0100, Maximiliano Sandoval wrote:
> These are seen on the Summary when creating a VM or container.
> 
> 

Applied, thanks!

I added a short sentence to the commit message that we already translate these
in other places.

[1/1] ui: mark Key and Value as translatable
      commit: 49323fe854ad80d69e7e1170d38d8972e7e54ab6




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-02-25 13:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-24 14:15 [PATCH manager] ui: mark Key and Value as translatable Maximiliano Sandoval
2026-02-25 13:44 ` applied: " Dominik Csapak

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal