all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH docs 0/3] rephrase and fix typos, add notes about QDevice removal
@ 2026-02-13 16:09 Nicolas Frey
  2026-02-13 16:09 ` [PATCH pve-docs 1/3] pveceph: fix typo Nicolas Frey
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Nicolas Frey @ 2026-02-13 16:09 UTC (permalink / raw)
  To: pve-devel

Some small typo fixes and a rephrase.

The last patch came out of a quick chat Friedrich and I had. I couldn’t
find anything to link to that actually says you need to remove the
QDevice before removing a cluster node in the relevant sections, so I
added it.

pve-docs:

Nicolas Frey (3):
  pveceph: fix typo
  pvecm: improve phrasing and use `pve` variable
  pvecm: add notes about needing to remove QDevice when removing a node

 pveceph.adoc |  2 +-
 pvecm.adoc   | 13 ++++++++++---
 2 files changed, 11 insertions(+), 4 deletions(-)


Summary over all repositories:
  2 files changed, 11 insertions(+), 4 deletions(-)

-- 
Generated by git-murpp 0.8.1



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH pve-docs 1/3] pveceph: fix typo
  2026-02-13 16:09 [PATCH docs 0/3] rephrase and fix typos, add notes about QDevice removal Nicolas Frey
@ 2026-02-13 16:09 ` Nicolas Frey
  2026-02-13 16:09 ` [PATCH pve-docs 2/3] pvecm: improve phrasing and use `pve` variable Nicolas Frey
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Nicolas Frey @ 2026-02-13 16:09 UTC (permalink / raw)
  To: pve-devel

Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
---
 pveceph.adoc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pveceph.adoc b/pveceph.adoc
index 2ddddf1..f6ca5f0 100644
--- a/pveceph.adoc
+++ b/pveceph.adoc
@@ -258,7 +258,7 @@ The configuration step includes the following settings:
   required.
   +
   Separating your Ceph traffic from the {pve} cluster communication (corosync),
-  and possible the front-facing (public) networks of your virtual guests, is
+  and possibly the front-facing (public) networks of your virtual guests, is
   highly recommended. Otherwise, Ceph's high-bandwidth IO-traffic could cause
   interference with other low-latency dependent services.
 
-- 
2.47.3




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH pve-docs 2/3] pvecm: improve phrasing and use `pve` variable
  2026-02-13 16:09 [PATCH docs 0/3] rephrase and fix typos, add notes about QDevice removal Nicolas Frey
  2026-02-13 16:09 ` [PATCH pve-docs 1/3] pveceph: fix typo Nicolas Frey
@ 2026-02-13 16:09 ` Nicolas Frey
  2026-02-13 16:09 ` [PATCH pve-docs 3/3] pvecm: add notes about needing to remove QDevice when removing a node Nicolas Frey
  2026-02-16 19:16 ` applied: [PATCH docs 0/3] rephrase and fix typos, add notes about QDevice removal Thomas Lamprecht
  3 siblings, 0 replies; 5+ messages in thread
From: Nicolas Frey @ 2026-02-13 16:09 UTC (permalink / raw)
  To: pve-devel

Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
---
noticed this while going through changes for the next commit
 pvecm.adoc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pvecm.adoc b/pvecm.adoc
index 0ed1bd2..1ea3077 100644
--- a/pvecm.adoc
+++ b/pvecm.adoc
@@ -362,8 +362,8 @@ Before a node can be removed from a cluster, you must ensure that it
 is no longer part of a Ceph cluster and that no Ceph resources or
 services are residing on it.
 
-In the following example, the cluster node `node4` will be removed from both,
-the Ceph and the Proxmox VE corosync cluster.
+In the following example, the cluster node `node4` will be removed from both
+the Ceph-, and {pve} corosync-cluster.
 
 ----
 node4# pvecm nodes
-- 
2.47.3




^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH pve-docs 3/3] pvecm: add notes about needing to remove QDevice when removing a node
  2026-02-13 16:09 [PATCH docs 0/3] rephrase and fix typos, add notes about QDevice removal Nicolas Frey
  2026-02-13 16:09 ` [PATCH pve-docs 1/3] pveceph: fix typo Nicolas Frey
  2026-02-13 16:09 ` [PATCH pve-docs 2/3] pvecm: improve phrasing and use `pve` variable Nicolas Frey
@ 2026-02-13 16:09 ` Nicolas Frey
  2026-02-16 19:16 ` applied: [PATCH docs 0/3] rephrase and fix typos, add notes about QDevice removal Thomas Lamprecht
  3 siblings, 0 replies; 5+ messages in thread
From: Nicolas Frey @ 2026-02-13 16:09 UTC (permalink / raw)
  To: pve-devel

there was already an entry for this in the FAQ section later in the
chapter, which could easily be overlooked.

Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
---
This came up when I was talking to @Friedrich about removing a cluster node
and then not finding the part to link to for needing to remove the QDevice.

IDK if notes are the proper way to link to this section here and whether duplicating
them is OK. After the doc for removing a cluster node was recently split up
(cc52fbaa15d9), I reckoned having it in each section would be fine

 pvecm.adoc | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/pvecm.adoc b/pvecm.adoc
index 1ea3077..79f98b3 100644
--- a/pvecm.adoc
+++ b/pvecm.adoc
@@ -323,6 +323,10 @@ was also part of a xref:chapter_pveceph[Ceph] cluster.
 If Ceph was not installed on your node, you can simply ignore the
 steps that mention it.
 
+NOTE: If your configuration contains a QDevice, you will need to remove it
+before removing the cluster node, as outlined in the FAQ
+xref:_adding_deleting_nodes_after_qdevice_setup[here].
+
 Prerequisites
 ~~~~~~~~~~~~~
 
@@ -377,7 +381,6 @@ Membership information
          4          1 node4 (local)
 ----
 
-
 . Start by removing the node from the Ceph cluster, this consists of multiple
   steps:
 
@@ -487,6 +490,10 @@ does not get accessed by multiple clusters. After setting up this storage, move
 all data and VMs from the node to it. Then you are ready to separate the
 node from the cluster.
 
+NOTE: If your configuration contains a QDevice, you will need to remove it
+before removing the cluster node, as outlined in the FAQ
+xref:_adding_deleting_nodes_after_qdevice_setup[here].
+
 WARNING: Ensure that all shared resources are cleanly separated! Otherwise you
 will run into conflicts and problems.
 
-- 
2.47.3




^ permalink raw reply	[flat|nested] 5+ messages in thread

* applied: [PATCH docs 0/3] rephrase and fix typos, add notes about QDevice removal
  2026-02-13 16:09 [PATCH docs 0/3] rephrase and fix typos, add notes about QDevice removal Nicolas Frey
                   ` (2 preceding siblings ...)
  2026-02-13 16:09 ` [PATCH pve-docs 3/3] pvecm: add notes about needing to remove QDevice when removing a node Nicolas Frey
@ 2026-02-16 19:16 ` Thomas Lamprecht
  3 siblings, 0 replies; 5+ messages in thread
From: Thomas Lamprecht @ 2026-02-16 19:16 UTC (permalink / raw)
  To: pve-devel, Nicolas Frey

On Fri, 13 Feb 2026 17:09:53 +0100, Nicolas Frey wrote:
> Some small typo fixes and a rephrase.
> 
> The last patch came out of a quick chat Friedrich and I had. I couldn’t
> find anything to link to that actually says you need to remove the
> QDevice before removing a cluster node in the relevant sections, so I
> added it.
> 
> [...]

Applied, thanks!

[1/3] pveceph: fix typo
      commit: 560431bb24824b478940fdb1fd755556e061ebe4
[2/3] pvecm: improve phrasing and use `pve` variable
      commit: 44404f0a79f5fed14b80cb29712e8efd89d842f9
[3/3] pvecm: add notes about needing to remove QDevice when removing a node
      commit: 7780a53b6127adc8183b46743158a2ee95a17fff




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-02-16 19:16 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-13 16:09 [PATCH docs 0/3] rephrase and fix typos, add notes about QDevice removal Nicolas Frey
2026-02-13 16:09 ` [PATCH pve-docs 1/3] pveceph: fix typo Nicolas Frey
2026-02-13 16:09 ` [PATCH pve-docs 2/3] pvecm: improve phrasing and use `pve` variable Nicolas Frey
2026-02-13 16:09 ` [PATCH pve-docs 3/3] pvecm: add notes about needing to remove QDevice when removing a node Nicolas Frey
2026-02-16 19:16 ` applied: [PATCH docs 0/3] rephrase and fix typos, add notes about QDevice removal Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal