* [PATCH proxmox-widget-toolkit v2] fix #4911: ui: network edit: allow empty bond-primary
@ 2026-02-10 10:13 Lukas Sichert
2026-02-13 10:35 ` applied: " Dominik Csapak
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Sichert @ 2026-02-10 10:13 UTC (permalink / raw)
To: pve-devel; +Cc: Lukas Sichert
Currently, when creating an active-backup bond, the bond-primary field
cannot be left blank, even though this value is optional in the backend.
If no value is set in the frontend, it sends the value '' to the
backend. There, it is interpreted as the name of an interface, which is
incorrect. This results in the error 'bond-primary: invalid format -
invalid network interface name '' ' being displayed.
The proxmoxtextfield component has a special handling that explicitly
excludes data with value '' from being sent to the backend. Hence, to
fix the bug, switch the bond-primary field from textfield to
proxmoxtextfield.
Additionally, set the deleteEmpty flag, so that devices
deleted in the UI are also deleted in the backend.
Signed-off-by: Lukas Sichert <l.sichert@proxmox.com>
---
src/node/NetworkEdit.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/node/NetworkEdit.js b/src/node/NetworkEdit.js
index 39c7e35..c945139 100644
--- a/src/node/NetworkEdit.js
+++ b/src/node/NetworkEdit.js
@@ -239,10 +239,11 @@ Ext.define('Proxmox.node.NetworkEdit', {
disabled: true,
});
- let primaryfield = Ext.createWidget('textfield', {
+ let primaryfield = Ext.createWidget('proxmoxtextfield', {
fieldLabel: 'bond-primary',
name: 'bond-primary',
value: '',
+ deleteEmpty: !me.isCreate,
disabled: true,
});
--
2.47.3
^ permalink raw reply [flat|nested] 2+ messages in thread* applied: [PATCH proxmox-widget-toolkit v2] fix #4911: ui: network edit: allow empty bond-primary
2026-02-10 10:13 [PATCH proxmox-widget-toolkit v2] fix #4911: ui: network edit: allow empty bond-primary Lukas Sichert
@ 2026-02-13 10:35 ` Dominik Csapak
0 siblings, 0 replies; 2+ messages in thread
From: Dominik Csapak @ 2026-02-13 10:35 UTC (permalink / raw)
To: pve-devel, Lukas Sichert
On Tue, 10 Feb 2026 11:13:43 +0100, Lukas Sichert wrote:
> Currently, when creating an active-backup bond, the bond-primary field
> cannot be left blank, even though this value is optional in the backend.
> If no value is set in the frontend, it sends the value '' to the
> backend. There, it is interpreted as the name of an interface, which is
> incorrect. This results in the error 'bond-primary: invalid format -
> invalid network interface name '' ' being displayed.
>
> [...]
Applied, thanks!
[1/1] fix #4911: ui: network edit: allow empty bond-primary
commit: 5e77066c82edd127aca60b388910dced8620d604
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-13 10:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-10 10:13 [PATCH proxmox-widget-toolkit v2] fix #4911: ui: network edit: allow empty bond-primary Lukas Sichert
2026-02-13 10:35 ` applied: " Dominik Csapak
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.