From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Daniel Kral <d.kral@proxmox.com>
Subject: applied: [PATCH container v2 4/4] setup: make the architecture fall back to amd64 for falsy values
Date: Fri, 6 Feb 2026 15:30:57 +0100 [thread overview]
Message-ID: <177038825450.2774896.5556117220640752606.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260206124513.310674-5-d.kral@proxmox.com>
On Fri, 06 Feb 2026 13:45:05 +0100, Daniel Kral wrote:
> The architecture fallback branch relied on detect_architecture(...)
> failing and therefore $arch being undef afterwards.
>
> However, if protected_call(sub { detect_architecture(...) }) itself
> returns a defined, falsy value, such as a empty string converted from an
> undef value, the 'arch' field will be set to that value, which will make
> the container fail to start.
>
> [...]
Applied, but as mentioned in my reply to 3/4 I ordered this earlier, as it's a
prerequisite for this patch, thanks!
[4/4] setup: make the architecture fall back to amd64 for falsy values
commit: e21afdcea18be498a7a4cebf6ad2df42ddfb9caf
next prev parent reply other threads:[~2026-02-06 14:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 12:45 [PATCH-SERIES container v2 0/4] add missing no-op methods for unmanaged CTs Daniel Kral
2026-02-06 12:45 ` [PATCH container v2 1/4] setup: plugin: add missing check_systemd_nesting stub Daniel Kral
2026-02-06 12:45 ` [PATCH container v2 2/4] fix #7270: setup: add no-op check_systemd_nesting for unmanaged CTs Daniel Kral
2026-02-06 12:45 ` [PATCH container v2 3/4] setup: add no-op detect_architecture " Daniel Kral
2026-02-06 13:09 ` Fiona Ebner
2026-02-06 14:30 ` Thomas Lamprecht
2026-02-06 15:04 ` Fiona Ebner
2026-02-06 14:30 ` applied: " Thomas Lamprecht
2026-02-06 12:45 ` [PATCH container v2 4/4] setup: make the architecture fall back to amd64 for falsy values Daniel Kral
2026-02-06 14:30 ` Thomas Lamprecht [this message]
2026-02-06 13:18 ` partially-applied: [PATCH-SERIES container v2 0/4] add missing no-op methods for unmanaged CTs Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177038825450.2774896.5556117220640752606.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.