all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH pve-network] sdn: bgp: fix invalid double slash in ipv6 network
@ 2026-01-22 13:30 Hannes Laimer
  2026-01-29 17:40 ` applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Hannes Laimer @ 2026-01-22 13:30 UTC (permalink / raw)
  To: pve-devel

The IPv6 mask was defined with a leading slash, which resulted in a
double slash when concatenated with the IP later for the final config
string.

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
 src/PVE/Network/SDN/Controllers/BgpPlugin.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/Network/SDN/Controllers/BgpPlugin.pm b/src/PVE/Network/SDN/Controllers/BgpPlugin.pm
index c84b384..447ebf1 100644
--- a/src/PVE/Network/SDN/Controllers/BgpPlugin.pm
+++ b/src/PVE/Network/SDN/Controllers/BgpPlugin.pm
@@ -113,7 +113,7 @@ sub generate_frr_config {
     # address-family unicast
     if (@peers) {
         my $ipversion = Net::IP::ip_is_ipv6($ifaceip) ? "ipv6" : "ipv4";
-        my $mask = Net::IP::ip_is_ipv6($ifaceip) ? "/128" : "32";
+        my $mask = Net::IP::ip_is_ipv6($ifaceip) ? "128" : "32";
 
         push(@{ $bgp->{"address-family"}->{"$ipversion unicast"} }, "network $ifaceip/$mask")
             if $loopback;
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* applied: [pve-devel] [PATCH pve-network] sdn: bgp: fix invalid double slash in ipv6 network
  2026-01-22 13:30 [pve-devel] [PATCH pve-network] sdn: bgp: fix invalid double slash in ipv6 network Hannes Laimer
@ 2026-01-29 17:40 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2026-01-29 17:40 UTC (permalink / raw)
  To: pve-devel, Hannes Laimer

On Thu, 22 Jan 2026 14:30:05 +0100, Hannes Laimer wrote:
> The IPv6 mask was defined with a leading slash, which resulted in a
> double slash when concatenated with the IP later for the final config
> string.
> 
> 

Applied, thanks!

[1/1] sdn: bgp: fix invalid double slash in ipv6 network
      commit: 33ce6447b7b904171c4c755ffbb42b3b59fec1b0




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-01-29 17:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-22 13:30 [pve-devel] [PATCH pve-network] sdn: bgp: fix invalid double slash in ipv6 network Hannes Laimer
2026-01-29 17:40 ` applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal