all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com,
	Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve-common] fix #7077: Improve error message for IDs shorter than 2 characters
Date: Wed, 21 Jan 2026 19:00:18 +0100	[thread overview]
Message-ID: <176901841189.2566480.18155097005731577003.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260121103407.187187-2-a.bied-charreton@proxmox.com>

On Wed, 21 Jan 2026 11:32:29 +0100, Arthur Bied-Charreton wrote:
> The regex in JSONSchema::parse_id requires at least 2 characters, but
> shorter IDs only failed with "contains illegal characters". Add explicit
> length check to return a clearer error message in this case.
> 
> 

Change looks alright as do the meta info like commit message, nice work!

Applied this one already, thanks!

[1/1] fix #7077: Improve error message for IDs shorter than 2 characters
      commit: d43c573d87dd374b200ec6366ad79175dc586012


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2026-01-21 18:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-21 10:32 [pve-devel] [PATCH 0/5] fix #7077: Improve ID validation error messages Arthur Bied-Charreton
2026-01-21 10:32 ` [pve-devel] [PATCH pve-common] fix #7077: Improve error message for IDs shorter than 2 characters Arthur Bied-Charreton
2026-01-21 18:00   ` Thomas Lamprecht [this message]
2026-01-21 10:32 ` [pve-devel] [PATCH pve-storage] fix #7077: Improve error message for IDS " Arthur Bied-Charreton
2026-01-21 10:32 ` [pve-devel] [PATCH proxmox] fix #7077: Improve error message for SDN IDs " Arthur Bied-Charreton
2026-01-21 10:32 ` [pve-devel] [PATCH pve-network 1/2] fix #7077: Improve error messages for ID length mismatch Arthur Bied-Charreton
2026-01-21 10:32 ` [pve-devel] [PATCH pve-network 2/2] fix #7077: Respect noerr flag in SDN ID validation Arthur Bied-Charreton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176901841189.2566480.18155097005731577003.b4-ty@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=a.bied-charreton@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal