all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, Hannes Laimer <h.laimer@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve-network] sdn: add missing new-line at the end of frr config and update tests
Date: Wed, 21 Jan 2026 18:00:23 +0100	[thread overview]
Message-ID: <176901476609.313340.10143985482491106115.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260121093455.7999-1-h.laimer@proxmox.com>

On Wed, 21 Jan 2026 10:34:55 +0100, Hannes Laimer wrote:
> We currently generate the FRR config file without a `\n` at the end, it
> works, but is technically not correct in UNIX. Most importantly when
> editing tests vim would add one when saving, this would then not match
> what we generate.

Applied with Gabriel's Acked-by, thanks!

[1/1] sdn: add missing new-line at the end of frr config and update tests
      commit: 3d9449686cd4a3427dda3e3ef9430b7630c3555b


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2026-01-21 17:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-21  9:34 [pve-devel] " Hannes Laimer
2026-01-21 10:56 ` Gabriel Goller
2026-01-21 17:00 ` Fiona Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=176901476609.313340.10143985482491106115.b4-ty@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=h.laimer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal