[pve-devel] [PATCH container] setup: centos: separate dns-search list with semicolons

[pve-devel] [PATCH container] setup: centos: separate dns-search list with semicolons

[Maximiliano Sandoval]

This is a followup of 6e08c550.

Unlike the previous commit, the key `dns-search` is not documented as
part of the manual page `nm-settings-keyfile(5)`. Here we rely solely on
lists being generally semicolon-separated in NetworkManager and the test
case `Test_Wireless_Connection` [1, 2, 3].

[1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/main/src/core/settings/plugins/keyfile/tests/test-keyfile-settings.c?ref_type=820e56c5df80d6f5a4019c82f0f60b3303ecfa17#L281
[2] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/main/src/core/settings/plugins/keyfile/tests/test-keyfile-settings.c?ref_type=820e56c5df80d6f5a4019c82f0f60b3303ecfa17#L370-L372
[3] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/main/src/core/settings/plugins/keyfile/tests/keyfiles/Test_Wired_Connection#L52

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/PVE/LXC/Setup/CentOS.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/PVE/LXC/Setup/CentOS.pm b/src/PVE/LXC/Setup/CentOS.pm
index 7bccca2..2469046 100644
--- a/src/PVE/LXC/Setup/CentOS.pm
+++ b/src/PVE/LXC/Setup/CentOS.pm
@@ -245,7 +245,7 @@ sub setup_network_with_networkmanager {
             }
             if (@name_servers_v4) {
                 $data .= "dns=" . join(';', @name_servers_v4) . "\n";
-                $data .= "dns-search=" . join(' ', PVE::Tools::split_list($searchdomains)) . "\n"
+                $data .= "dns-search=" . join(';', PVE::Tools::split_list($searchdomains)) . "\n"
                     if $searchdomains;
             }
         } else {
@@ -271,7 +271,7 @@ sub setup_network_with_networkmanager {
             }
             if (@name_servers_v6) {
                 $data .= "dns=" . join(';', @name_servers_v6) . "\n";
-                $data .= "dns-search=" . join(' ', PVE::Tools::split_list($searchdomains)) . "\n"
+                $data .= "dns-search=" . join(';', PVE::Tools::split_list($searchdomains)) . "\n"
                     if $searchdomains;
             }
         } else {
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH container] setup: centos: separate dns-search list with semicolons

[Fabian Grünbichler]

On Tue, 30 Dec 2025 13:55:10 +0100, Maximiliano Sandoval wrote:
> This is a followup of 6e08c550.
> 
> Unlike the previous commit, the key `dns-search` is not documented as
> part of the manual page `nm-settings-keyfile(5)`. Here we rely solely on
> lists being generally semicolon-separated in NetworkManager and the test
> case `Test_Wireless_Connection` [1, 2, 3].
> 
> [...]

Applied, thanks!

[1/1] setup: centos: separate dns-search list with semicolons
      commit: 963a663826390efba9ee80126c8e47da56041ee9

Best regards,
-- 
Fabian Grünbichler <f.gruenbichler@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel