From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH container] config: document that nameserver is a list
Date: Thu, 15 Jan 2026 14:16:04 +0100 [thread overview]
Message-ID: <1768482564.1132gmovld.astroid@yuna.none> (raw)
In-Reply-To: <20251218151944.869104-1-m.sandoval@proxmox.com>
On December 18, 2025 4:19 pm, Maximiliano Sandoval wrote:
> And for good measure, mention that it is comma-separated (even though it
> can also be space-separated).
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>
> This came up while working on [1] where it took me some time to figure out the
> format.
>
> The rendered docs reads at the moment:
>
>> nameserver: <string>
>>
>> Sets DNS server IP address for a container. Create will automatically use the setting from the host if neither searchdomain nor nameserver are set.
>
> which does not indicate this might be a list nor how it is separated.
wouldn't it make more sense to make the doc generation include that
information automatically? a format name with -list at the end always
means that it is a \0 or ,;\s separated list of values of the "child"
format.. so instead of <string>, this could print
<lxc-ip-with-ll-iface>[, <lxc-ip-with-ll-iface>[, ..]]
for example, with all the required information already available in the
schema..
>
>
> [1] https://lore.proxmox.com/all/20251218150126.832313-1-m.sandoval@proxmox.com/
>
> src/PVE/LXC/Config.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
> index 6be38a2..7cb4e5c 100644
> --- a/src/PVE/LXC/Config.pm
> +++ b/src/PVE/LXC/Config.pm
> @@ -606,7 +606,7 @@ my $confdesc = {
> type => 'string',
> format => 'lxc-ip-with-ll-iface-list',
> description =>
> - "Sets DNS server IP address for a container. Create will automatically use the setting from the host if you neither set searchdomain nor nameserver.",
> + "Comma-separated list of IP addresses. Sets the addresses of the DNS servers of the container. Create will automatically use the setting from the host if you neither set searchdomain nor nameserver.",
> },
> timezone => {
> optional => 1,
> --
> 2.47.3
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2026-01-15 13:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 15:19 Maximiliano Sandoval
2026-01-15 13:16 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1768482564.1132gmovld.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.