[pve-devel] applied-series: [PATCH pve-common v1 00/23] Document PVE::SectionConfig Peculiarities

["Fabian Grünbichler" <f.gruenbichler@proxmox.com>]

On Fri, 19 Dec 2025 20:44:35 +0100, Max R. Carrara wrote:
> Document PVE::SectionConfig Peculiarities - v1
> ==============================================
> 
> This was a long overdue series that adds a bunch of unit tests and
> documentation updates for PVE::SectionConfig. The main motivation for
> this series is me running somewhat regularly into new discoveries when
> using PVE::SectionConfig for other purposes or investigating how certain
> schemas are generated.
> 
> [...]

Applied with two follow-ups, thanks!

I sent some questions as replies to individual patches, while the tests
currently document the status quo, I am not sure that that status is correct in
all cases.

It would also be great to have some test coverage for:
- description overrides
- properties with different types and/or constraints (pattern, minimum values,
  enums with different values)

might show us some edge cases where behaviour doesn't make sense at the moment
and the implementation should become stricter.

[01/23] sectionconfig: remove unused variable in get_property_schema()
        commit: 257bd0836da5e04178be1205e216b24463c7d9ee
[02/23] tests: sectionconfig: add comparison test structure
        commit: c873f9a002063780000f920b1b8d783a0218dfb9
[03/23] tests: sectionconfig: add test case for fixed props in updateSchema
        commit: 38ccad8562385fa66c717c2a1e98d6453252de71
[04/23] tests: sectionconfig: add case for unused properties
        commit: a64637b34e2aead3983be740857e95b57d46d853
[05/23] tests: sectionconfig: add case for unused optional default properties
        commit: e79bf3aa729210aabd9d418aac2cf260e6c10a61
[06/23] tests: sectionconfig: add case for opt. default prop being req. once
        commit: 79a5670a1c147abf69ae87de6c10d99536d52cdf
[07/23] tests: sectionconfig: add case for opt. default prop requirde by all
        commit: cb7b99ab8a5138753a0cc393c17c470e0ef2366d
[08/23] tests: sectionconfig: add case for unused required default properties
        commit: 99440ee0727a72f796db613bb5bea16f5be04bfb
[09/23] tests: sectionconfig: add case for req. default prop being req. once
        commit: 1808f17ab93e15d53c1b19d2b1df56a153df837d
[10/23] tests: sectionconfig: add case for required default prop req. by all
        commit: 2111fa318db7ef28b8748321e8ef263708a69533
[11/23] tests: sectionconfig: add case for required default props opt. for all
        commit: aea956a4da0c11461d161fe0d52a2801ac5df5e2
[12/23] tests: sectionconfig: add isolated mode test structure
        commit: e47d3c6ac09c5223b972b9c72ec47ea39361d9d1
[13/23] tests: sectionconfig: add case for an ident. prop on two plugins
        commit: ade73858b66e6eb70a8329c79fbbdf348606f787
[14/23] tests: sectionconfig: add case for same prop. w/ different optionality
        commit: d6fa9be42d9fffa8f233641a52fc3d90cfcda2c5
[15/23] tests: sectionconfig: add case for differing opt. default prop uses
        commit: bd29332feae706d7f9364896a29469099b8f0062
[16/23] tests: sectionconfig: add case for differing req. default prop uses
        commit: 78674e62bb9a83c262756969d6c37a9b9b6fc155
[17/23] sectionconfig: correct docs regarding global props in unified mode
        commit: 295acd52aee7c9b04bb7ef9b52e0ab1d6af1e7de
[18/23] sectionconfig: reword docs regarding property usage in isolated mode
        commit: a0892c3abbdcaad7e268e42db4b4fcc462a54b2e
[19/23] sectionconfig: extend / correct docstring of `private()` method
        commit: e375250709714e03d29ed78bf5e836ff444fa3f8
[20/23] sectionconfig: note that a prop must be defined through a JSONSchema
        commit: 086c7dc201cd5d608b8466b83bde5d5b907668ef
[21/23] sectionconfig: note that props added by plugins are always optional
        commit: 735c530ec6e756cbf7b26fca947d855a50423111
[22/23] sectionconfig: note that `createSchema()` is universal for all plugins
        commit: 53e7a8b43a602ccdc41f8a01f8de297b6d766644
[23/23] sectionconfig: correct example in docstring of `updateSchema()`
        commit: 57ff33b753b35cffc997cc0f3338c4b7936485a5

Best regards,
-- 
Fabian Grünbichler <f.gruenbichler@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel