[pve-devel] [PATCH qemu-server master+stable-bookworm] migration: vm start: avoid config write when there are left-over VM-state-related properties

[pve-devel] [PATCH qemu-server master+stable-bookworm] migration: vm start: avoid config write when there are left-over VM-state-related properties

[Fiona Ebner]

The remove_left_over_vmstate_opts() function might write the
configuration, so it cannot be called in the context of a migration,
where the configuration file will be moved over from the source node
later. As reported in the enterprise support, this could cause an
error like:
> close (rename) atomic file '/etc/pve/nodes/XYZ/qemu-server/211.conf' failed: File exists

Fixes: 0db14e60 ("vm start: remove left-over VM-state-related properties")
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/QemuServer.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index 69991843..53001b9b 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -5956,7 +5956,7 @@ sub vm_start_nolock {
         }
         delete $conf->@{qw(lock vmstate running-nets-host-mtu runningmachine runningcpu)};
         PVE::QemuConfig->write_config($vmid, $conf);
-    } elsif (!$conf->{vmstate}) {
+    } elsif (!$conf->{vmstate} && !$migratedfrom) {
         remove_left_over_vmstate_opts($vmid, $conf);
     }
 
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH qemu-server master+stable-bookworm] migration: vm start: avoid config write when there are left-over VM-state-related properties

[Fabian Grünbichler]

On Fri, 02 Jan 2026 14:17:32 +0100, Fiona Ebner wrote:
> The remove_left_over_vmstate_opts() function might write the
> configuration, so it cannot be called in the context of a migration,
> where the configuration file will be moved over from the source node
> later. As reported in the enterprise support, this could cause an
> error like:
> > close (rename) atomic file '/etc/pve/nodes/XYZ/qemu-server/211.conf' failed: File exists
> 
> [...]

Applied to master, applied with fuzz fix to stable-bookworm

master:

[1/1] migration: vm start: avoid config write when there are left-over VM-state-related properties
      commit: be61afa1c180c0e415245fc48489dfdb216153fd

stable-bookworm:

[1/1] migration: vm start: avoid config write when there are left-over VM-state-related properties
      commit: f303df12945fce59db4cceebe635d41e536277f4

Best regards,
-- 
Fabian Grünbichler <f.gruenbichler@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel